Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/post mvp #267

Open
wants to merge 166 commits into
base: main
Choose a base branch
from
Open

Feature/post mvp #267

wants to merge 166 commits into from

Conversation

loganpaulmatheny
Copy link

What I did: Merge the accessibility features with the POST/GET request.

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Styling
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

What's next? A big breath of relief...

Jnguyen615 and others added 30 commits August 26, 2023 14:35
@Jnguyen615
Add pull request template
620b7cb
@Jnguyen615
Add basic html structure
e342bad
@Jnguyen615
Update issue templates
9081f82 
Created a new pr template
@MaryBruff
Merge pull request #29 from Jnguyen615/feature/basic-html
d0340ec 
Feature/basic html
@loganpaulmatheny
Create basic filter functions
72dd730
@MaryBruff
change html class names
93df599
@MaryBruff
add starting css
9c5fbc9
@MaryBruff
move cards insert
a85c257
@MaryBruff
add new sections to be added in html
fee67e4
@Jnguyen615
Merge pull request #30 from Jnguyen615/feature/basic-css
e202f51 
Feature/basic css
@MaryBruff
Merge pull request #31 from Jnguyen615/feature/recipe-filter-functions
95111e3 
Create basic filter functions
@loganpaulmatheny
Begin recipe card functionality
45a315e
@loganpaulmatheny
Merge branch 'main' into feature/recipe-cards
ac44a0e
@loganpaulmatheny
Complete basic create and display recipe card functionality
7eadb19
@loganpaulmatheny
Create tags
35eecd8
@loganpaulmatheny
Add minor changes to tags
eea0753
@MaryBruff
Merge pull request #34 from Jnguyen615/feature/18-featuretags-html
6cef0ad 
Feature/18 featuretags html
@loganpaulmatheny
Test if a tag has a specific class
af7e274
@loganpaulmatheny
Complete the filter by tag functionality
aa01c78
@loganpaulmatheny
Highlight active tags
9adf164
@loganpaulmatheny
Start work on how to work with multiple tags
8c2669b
@loganpaulmatheny
Do a little work on search functionality (wrong branch)
d3989e6
@loganpaulmatheny
Allow the ability to search for recipes
1f3a0ae
@Jnguyen615
Merge pull request #36 from Jnguyen615/feature/26tag-filtering
9e16198 
Feature/26tag filtering
@Jnguyen615
Merge pull request #38 from Jnguyen615/feature/search-recipe
1751e2d 
Feature/search recipe
@loganpaulmatheny
Complete filter by multiple tag functionality
4983b3e
@MaryBruff
Merge pull request #39 from Jnguyen615/feature/filter-multiple-tags
3bba9b4 
Complete filter by multiple tag functionality
@MaryBruff
add get recipe instructions
def4a5d
@MaryBruff
add 6 passing tests for get recipe instructions
5823e1b
@loganpaulmatheny
Merge pull request #43 from Jnguyen615/feature/feature/returnDirections
241081a 
Feature/return directions
Jnguyen615 and others added 30 commits September 5, 2023 14:50
@Jnguyen615
Start the read me
e366325
@Jnguyen615
Change order of tags to make them easier to read on page
3e923f9
@MaryBruff
add more tests to cover more edge cases
c13c85e
@Jnguyen615
Add element tag to error message for styling
77761a5
@loganpaulmatheny
Merge pull request #78 from Jnguyen615/test/writeRemainingTests
49b9843 
Test/write remaining tests
@Jnguyen615
Fix formatting on all files
2731413
@Jnguyen615
Finish out the read me
33bbd50
@Jnguyen615
Fix stying for the delete button on the recipe card
93f2293
@MaryBruff
Merge pull request #79 from Jnguyen615/feature/error-message
5f5e7dc 
Feature/error message
@MaryBruff
add en lang and tab function to html
2f55fa6
@loganpaulmatheny
Move icons so they are not 'squished' to the sides of the blownup recipe
0049bc9
@loganpaulmatheny
Save comments to initiate POST
f421bc0
@loganpaulmatheny
Have a bunch of problem solving pseduocode.
2c81f2b
@loganpaulmatheny
Complete the post request to add recipes to a user
39d4f68
@Jnguyen615
Merge pull request #92 from Jnguyen615/feature/post-mvp
16d96e1 
Feature/post mvp
@MaryBruff
add tab index
d5c3e69
@MaryBruff
add alt text to each recipe card
93e2b8d
@MaryBruff
add tab index to each recipe card
8c63e16
@MaryBruff
remove empty spacing
b0dc61f
@MaryBruff
remove empty spacing
98bef01
@MaryBruff
add starter code for tabbing through site no mouse click
1e768a1
@MaryBruff
Merge branch 'main' of feature/lighthouse-html
8fb3704
@loganpaulmatheny
Update POST request and GET request so that when a user clicks saved …
63fd148 
…recipes, they're viewing the database upates in the DM
@loganpaulmatheny
Update the user from the POSTed data
313674f
@loganpaulmatheny
Update currentUser from the POSTed data
6795713
@MaryBruff
add missing icon section tag
6da9880
@loganpaulmatheny
Merge pull request #94 from Jnguyen615/feature/lighthouse-html
8a6525d 
Feature/lighthouse html
@loganpaulmatheny
Delete a throw in apiCall
06b184a
@loganpaulmatheny
Merge branch 'main' into feature/post-mvp
8ab6121
@loganpaulmatheny
Merge accessibility features and POST/GET cycle
41e6a45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loganpaulmatheny @Jnguyen615 @MaryBruff