Sentry Integration #81
Conversation
lib/log/main.go
Outdated
| @@ -17,6 +24,10 @@ var Log *zap.SugaredLogger | |||
| // safe, but has a clunkier API). See: https://godoc.org/go.uber.org/zap#hdr-Choosing_a_Logger | |||
| var RawLog *zap.Logger | |||
|
|
|||
| type Client = sentry.Client | |||
There was a problem hiding this comment.
nit: I feel like this alias is more confusing, since there's already so many things called Client, and sentry.Client is more descriptive
There was a problem hiding this comment.
Good point -- this was copied from the tulip/sentry library, but I agree, I'll remove the alias
| } | ||
|
|
||
| func sentryInit(log *zap.Logger) *zap.Logger { | ||
| errConfig := config.ParseEnv() |
There was a problem hiding this comment.
surely this is already called somewhere else in the code... is it idempotent? Should we be initing the config here and passing it through?
There was a problem hiding this comment.
It is idempotent, but I did consider passing it through. It's just that it would touch a lot more code to do so -- not sure the best solution here
lib/log/main.go
Outdated
| if errSentry != nil { | ||
| // this is called before log is initialized | ||
| fmt.Fprintf(os.Stderr, "Failed to initialize Sentry: %s\n", errSentry) | ||
| return log |
There was a problem hiding this comment.
Probably, since it would only reach this is if SentryEnabled==true
lib/log/main.go
Outdated
| } | ||
|
|
||
|
|
Adds Sentry support via the following environmental variables:
OTR_SENTRY_ENABLED
OTR_SENTRY_DSN
OTR_SENTRY_MODE
OTR_SENTRY_RELEASE
OTR_SENTRY_ENVIRONMENT