Skip to content

Commit f743455

Browse files
authored
Merge branch 'main' into fix-firefox-world
2 parents 8dc807a + 95084d5 commit f743455

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGES.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Fixes:
1515
- Refines the generateFileName method to accurately compute zip file names ([366](https://github.com/freelawproject/recap/issues/366), [399](https://github.com/freelawproject/recap-chrome/pull/399)).
1616
- Improves the reliability of PACER case ID retrieval on attachment pages ([369](https://github.com/freelawproject/recap/issues/369), [400](https://github.com/freelawproject/recap-chrome/pull/400)).
1717
- Fix setDefaultOptions in updateToolbarButton([403](https://github.com/freelawproject/recap-chrome/pull/403))
18+
- Ensure we call sendResponse even when notifications are disabled([405](https://github.com/freelawproject/recap-chrome/pull/405))
1819
- Use chrome.scripting.ExecutionWorld.MAIN for firefox compatibility ([404](https://github.com/freelawproject/recap-chrome/pull/404))
1920

2021

src/utils/background_notifier.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ export const handleBackgroundNotification = (req, sender, sendResponse) => {
6464
break;
6565
case 'showUpload':
6666
chrome.storage.local.get('options', (items) => {
67-
if (!items || !items.options.show_notifications) return;
68-
showNotification(title, message);
67+
if (items && items.options.show_notifications)
68+
showNotification(title, message);
6969
sendResponse({ status: 'success ' });
7070
});
7171
break;

0 commit comments

Comments
 (0)