Skip to content

If a user goes to /dashboard, show them an empty state that tells them to login #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 27, 2025
Merged

If a user goes to /dashboard, show them an empty state that tells them to login #955

merged 7 commits into from
Apr 27, 2025

Conversation

MustafaMulla29
Copy link
Contributor

@MustafaMulla29 MustafaMulla29 commented Apr 26, 2025 •
edited
Loading

/claim #953

FIXES #953

image

@MustafaMulla29 MustafaMulla29 requested review from seveibar, imrishabh18 and a team as code owners April 26, 2025 06:38
@algora-pbc algora-pbc bot mentioned this pull request Apr 26, 2025
Closed
@MustafaMulla29
Copy link
Contributor Author

@seveibar should i remove the "Your recent snippets" part as well?(when the user is not logged in)

ArnavK-09
ArnavK-09 reviewed Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@ArnavK-09 ArnavK-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
padding / margin issue on small screens

@MustafaMulla29
Copy link
Contributor Author

@ArnavK-09
image

ArnavK-09
ArnavK-09 approved these changes Apr 26, 2025
View reviewed changes
Copy link
Collaborator

@ArnavK-09 ArnavK-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here can be lil margin , then lgtm

image

@MustafaMulla29
Copy link
Contributor Author

image

image

imrishabh18
imrishabh18 requested changes Apr 26, 2025
View reviewed changes
Copy link
Member

@imrishabh18 imrishabh18 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ximage

Also, remove the reference of Snippets from the trending and Latest section to Packages

@MustafaMulla29
Copy link
Contributor Author

ximage

Also, remove the reference of Snippets from the trending and Latest section to Packages

Yea I had thought, asked above

@MustafaMulla29
Copy link
Contributor Author

@imrishabh18
image

@seveibar
Copy link
Contributor

killer reviews @ArnavK-09 !!! Appreciated!

@seveibar
Copy link
Contributor

likewise @imrishabh18, nice catch on Your Recent Snippets

@seveibar
Copy link
Contributor

@MustafaMulla29 i think it might be a bit better with the border removed and additional margin on the top and bottom. I just attempted to redeploy your branch to vercel so that I can try to make the css modifications. It might be acceptable as is, but I think we should try it without the border

@seveibar
Copy link
Contributor

seveibar commented Apr 26, 2025 •
edited
Loading

Original

image

My Recommendation, top margin + no border

image

@MustafaMulla29
Copy link
Contributor Author

@MustafaMulla29 i think it might be a bit better with the border removed and additional margin on the top and bottom. I just attempted to redeploy your branch to vercel so that I can try to make the css modifications. It might be acceptable as is, but I think we should try it without the border

Ok I'll make changes

@seveibar seveibar merged commit 5ea5ece into tscircuit:main Apr 27, 2025
4 of 5 checks passed
@MustafaMulla29 MustafaMulla29 deleted the feat/dashboard-login branch April 27, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrishabh18 imrishabh18 imrishabh18 approved these changes

@ArnavK-09 ArnavK-09 ArnavK-09 approved these changes

@seveibar seveibar Awaiting requested review from seveibar seveibar is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If a user goes to /dashboard, show them an empty state that tells them to login
4 participants
@MustafaMulla29 @seveibar @imrishabh18 @ArnavK-09