-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed:quickstart page responsiveness #95
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aaecced
fixed:quickstart page responsiveness
ajmalrazaqbhatti e6ce20f
updated:flex to grid
ajmalrazaqbhatti a7974f9
format
ajmalrazaqbhatti 5a1034d
updated:playwright/test version
ajmalrazaqbhatti 8830e5a
Update package.json
ajmalrazaqbhatti e0335a4
Merge branch 'tscircuit:main' into main
ajmalrazaqbhatti 689854f
Merge branch 'tscircuit:main' into main
ajmalrazaqbhatti 2cd8cdc
upadted:col-3 to col-4 & quickstart-page snapshots
ajmalrazaqbhatti af1d2a4
format
ajmalrazaqbhatti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -46,7 +46,7 @@ export const QuickstartPage = () => { | |||||
{isLoading ? ( | ||||||
<div>Loading...</div> | ||||||
) : ( | ||||||
<div className="grid grid-cols-4 gap-4"> | ||||||
<div className="grid grid-cols-1 md:grid-cols-3 gap-4"> | ||||||
{mySnippets?.slice(0, 6).map((snippet) => ( | ||||||
<Link | ||||||
key={snippet.snippet_id} | ||||||
|
@@ -73,14 +73,16 @@ export const QuickstartPage = () => { | |||||
|
||||||
<div className="mb-8"> | ||||||
<h2 className="text-xl font-semibold mb-4">Start Blank Snippet</h2> | ||||||
<div className="grid grid-cols-4 gap-4"> | ||||||
<div className="grid grid-cols-1 md:grid-cols-3 gap-4"> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{blankTemplates.map((template, index) => ( | ||||||
<Link | ||||||
key={index} | ||||||
href={ | ||||||
template.disabled | ||||||
? "#" | ||||||
: `/editor?template=${template.name.toLowerCase().replace(/ /g, "-")}` | ||||||
: `/editor?template=${template.name | ||||||
.toLowerCase() | ||||||
.replace(/ /g, "-")}` | ||||||
} | ||||||
> | ||||||
<Card | ||||||
|
@@ -103,7 +105,7 @@ export const QuickstartPage = () => { | |||||
|
||||||
<div className="mt-12"> | ||||||
<h2 className="text-xl font-semibold mb-4">Import as Snippet</h2> | ||||||
<div className="grid grid-cols-3 gap-4"> | ||||||
<div className="grid grid-cols-1 md:grid-cols-3 gap-4"> | ||||||
{[ | ||||||
{ name: "KiCad Footprint", type: "footprint" }, | ||||||
{ name: "KiCad Project", type: "board" }, | ||||||
|
@@ -159,11 +161,13 @@ export const QuickstartPage = () => { | |||||
<h2 className="text-xl font-semibold mb-4 mt-12"> | ||||||
Start from a Template | ||||||
</h2> | ||||||
<div className="grid grid-cols-3 gap-4"> | ||||||
<div className="grid grid-cols-1 md:grid-cols-3 gap-4"> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{templates.map((template, index) => ( | ||||||
<Link | ||||||
key={index} | ||||||
href={`/editor?template=${template.name.toLowerCase().replace(/ /g, "-")}`} | ||||||
href={`/editor?template=${template.name | ||||||
.toLowerCase() | ||||||
.replace(/ /g, "-")}`} | ||||||
> | ||||||
<Card className="hover:shadow-md transition-shadow rounded-md"> | ||||||
<CardHeader className="p-4"> | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.