-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed:Search box doesn't render well in small views and dashboard responsiveness #85
Conversation
@theajmalrazaq is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Can you show a screenshot with a mobile view |
Ah mobile view is different. This fix seems OK but i think we might want to improve the search bar there- its super small on md. I think maybe we could use a shadcn command modal when someone clicks the box on small screens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@seveibar i also made dashboard responsive on mobile kindly review and merge |
I would run "bun format" after editing, the first pr for a person on github i have to manually approve workflows |
Hi @seveibar, |
No worries! Just letting you know the first pr is always tricky and you might have to ping me more often 😁 |
Haha, I think I’ve already pinged you more than 10 times! 😅 I really love your project and I’m excited to contribute more, especially with frontend bugs. You can definitely expect more pings from me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, future contributions will auto-run checks which will make things easier
i have fixed issue #83 Search box doesn't render well in small views please add hacktobefest label
![image](https://private-user-images.githubusercontent.com/127989125/377722618-7584448f-9988-450a-8b7f-4633a9f82535.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTE2OTUsIm5iZiI6MTczODg5MTM5NSwicGF0aCI6Ii8xMjc5ODkxMjUvMzc3NzIyNjE4LTc1ODQ0NDhmLTk5ODgtNDUwYS04YjdmLTQ2MzNhOWY4MjUzNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwMTIzMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jM2FmOGNlMzIyNzJjZjE4YzZkYzhmNTY5MjYxMGI0OWViMjhmNGY1NmJhNzA0ZTBmZmFkOTIzMjI4MTA2ZGQ3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.BlLiqCWbPI9svCNn6WYt3mnT1Zb-gMYWAGbeUyJrku0)