Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fake-snippets-api): missing package_release/get logic #636

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ArnavK-09
Copy link
Contributor

@ArnavK-09 ArnavK-09 commented Feb 3, 2025

@imrishabh18
Copy link
Member

It is not missing logic, our registy-api doesn't use the package_name_with_version so we are just faking it here the same way.

Probably we need to update the package_name_with_version in the registry-api as well.

cc: @seveibar

@ArnavK-09
Copy link
Contributor Author

ArnavK-09 commented Feb 3, 2025

It is not missing logic, our registy-api doesn't use the package_name_with_version so we are just faking it here the same way.

Probably we need to update the package_name_with_version in the registry-api as well.

cc: @seveibar

uhhh, but in production api bump thing is working with same prop

https://github.com/ArnavK-09/cli/blob/push/cli%2Fpush%2Fregister.ts#L125-L143

but not with fake

@imrishabh18
Copy link
Member

@ArnavK-09 Just checked the repo, yeah we are using the package_name_with_version. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants