-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #175: zoom effect for schematic view #178
Conversation
@rohittcodes is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
Lemme know if it's okay, I forgot this point,
I can iterate over the solution and will try to add the same to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done! Yes ideally this math is included in the useMouseMatrixTransform
library- otherwise it's difficult for others to maintain who are less familiar with matrix math
Also, to get the checks to pass just run bun format
.
Thanks really awesome work!
okay sure! |
@seveibar won't this be ideal if I work on the particular package, where the function is implemented? or is it good to be merged? I'm talking about this repo: use-mouse-matrix-transform |
Yea this is in part why I increased the bounty. First you have to reproduce the issue inside of |
Hi, I solved this issue in the use-mouse-matrix-transform by zooming the only required element to zoom instead of zooming every part of canvas. I hope this help please check out issue #3 of use-mouse-matrix-transform. |
i guess the issue isn't with the
the issue which the example in the referenced repo was facing because of the |
@rohittcodes the code looks ok, but are all these changes necessary? Can you reduce it to the minimum set of things that fix the issue? If it's just adding |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
confirmed fix on preview, waiting to see if code can be reduced |
yeah reduced it! it was just the fix.mp4 |
@seveibar you can review it. it was just the css property which we were missing most probably. |
schematic-zoom.mp4
/claim #175
fixes: #175