Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds snippet type to the url for copy url #137

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mrudulpatil18
Copy link
Contributor

Issue: #129

  • Updated encodeTextToUrlHash to add snippet type to the URL.
  • If not explicitly specified : Defaults to board if <board is detected in code; otherwise package.

Copy link

vercel bot commented Oct 29, 2024

@mrudulpatil18 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always better to keep prefixes with type, data or other vars that are often ambiguous in different contexts. e.g. we could support order_type, template_type or other url params in the future with that kind of name

src/lib/encodeTextToUrlHash.ts Outdated Show resolved Hide resolved
src/lib/encodeTextToUrlHash.ts Outdated Show resolved Hide resolved
@seveibar seveibar merged commit 46f0816 into tscircuit:main Oct 30, 2024
3 of 5 checks passed
@mrudulpatil18 mrudulpatil18 deleted the issue_129 branch October 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants