feat: manual-edits.json file added to dropdown #134
Conversation
imrishabh18
commented
Oct 29, 2024
imrishabh18
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
imrishabh18
changed the title
There was a problem hiding this comment.
Note before merging: there is an important change that will break production with the apiUrl, make sure to revert that line!
Look good, i think more code is now in CodeEditor when our goal should be to reduce the size of CodeEditor since its so complex. Could we make the CodeEditorHeader a separate component to hopefully start to break down that massive component?
src/components/CodeEditor.tsx
Outdated
| @@ -93,10 +117,9 @@ export const CodeEditor = ({ | |||
| const pathInPackage = fullPackageName.split("/").slice(1).join("/") | |||
| const jsdelivrPath = `${packageName}${pathInPackage ? `/${pathInPackage}` : ""}` | |||
| return fetch( | |||
| `${apiUrl}/snippets/download?jsdelivr_resolve=${input.includes("/resolve/")}&jsdelivr_path=${encodeURIComponent(jsdelivrPath)}`, | |||
| `/snippets/download?jsdelivr_resolve=${input.includes("/resolve/")}&jsdelivr_path=${encodeURIComponent(jsdelivrPath)}`, | |||
There was a problem hiding this comment.
This apiUrl is important, without it production wont go to the right server
src/components/CodeEditor.tsx
Outdated
| }) | ||
| } | ||
| } | ||
| }, [code]) | ||
| }, [files, currentFile]) |
There was a problem hiding this comment.
I think we should probably keep this the same, we could also make "code = files["index.tsx"]
| }, [files, currentFile]) | |
| }, [files["index.tsx"]]) |
This code sometimes can cause the cursor to jump while editing if it fires too often, or typescript to not be typechecked if it fires late
src/components/CodeEditor.tsx
Outdated
| if (ataRef.current) { | ||
| ataRef.current(code) | ||
| if (ataRef.current && currentFile === "index.tsx") { | ||
| ataRef.current(`${DEFAULT_IMPORTS}${files["index.tsx"]}`) |
There was a problem hiding this comment.
I think we should keep the "code" alias to simplify the diff imo
|
Another random note, this code can be a bit sensitive to changes, so definitely test stuff like editing code and making sure new typescript imports are recognized and dynamically imported etc. also that the cursor is stable when editing. We could potentially incorporate that into a playwright test later |
|
Editing and formatting, both are looking good. Screen.Recording.2024-10-29.at.8.23.26.PM.mov |
