Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test footprinter default num_pins, and readonly params #262

Open
ShiboSoftwareDev opened this issue Nov 20, 2024 · 11 comments
Open

test footprinter default num_pins, and readonly params #262

ShiboSoftwareDev opened this issue Nov 20, 2024 · 11 comments

Comments

@ShiboSoftwareDev
Copy link
Contributor

ShiboSoftwareDev commented Nov 20, 2024

  • since num_pins should be present in all footprints, remove the "Number of Pins" input field.
  • make sure to figure out which params are readonly and not display an input field for them.
    Eg. If a component has a readonly pitch param, I wouldn't have the option to change it
@seveibar
Copy link
Contributor

/bounty $15

Copy link

algora-pbc bot commented Nov 23, 2024

💎 $15 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #262 with your implementation plan
  2. Submit work: Create a pull request including /claim #262 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/tscircuit.com!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @techmannih Nov 26, 2024, 11:49:17 AM WIP

@techmannih
Copy link
Contributor

techmannih commented Nov 26, 2024

/attempt #262

@techmannih
Copy link
Contributor

@seveibar @ShiboSoftwareDev
I believe you want to remove the "Number of Pins" input field and ensure that readonly parameters, such as "Footprint String," are not displayed as input fields. Similarly, other parameters like "Number of Pins" (num_pins), "Pitch" (p), "Inner Diameter" (id), and "Outer Diameter" (od) should also be made readonly and not have input fields.

Please confirm if my understanding is correct, and feel free to share any suggestions you may have.

Image

@ShiboSoftwareDev
Copy link
Contributor Author

ShiboSoftwareDev commented Nov 26, 2024

Remove number of pins because you should be able to change it from the input under 'Parameters'.
Now the Parameters are sometimes readonly and sometimes are not, this depends on their zod type created in the footprinter repo, only readonly paramters should not be editable.

@techmannih
Copy link
Contributor

techmannih commented Nov 26, 2024

Thanks for responding! Sure, I got your point. I have started work on it.

@techmannih
Copy link
Contributor

techmannih commented Nov 26, 2024

@ShiboSoftwareDev please check

20241126190805.mp4

@ShiboSoftwareDev
Copy link
Contributor Author

ShiboSoftwareDev commented Nov 26, 2024

@techmannih as I said for the input fields under 'Parameters' only some of them are readonly. For example: Image
only the num_pins param for this footprint is readonly(z.literal) and all the other params should be editable.

  • also make the num_pins input field behave like the old one which you removed and append the number in the correct position. i.e. it doesn't behave like the other input fields

@techmannih
Copy link
Contributor

@ShiboSoftwareDev pease check, Now the num_pins behaves like the other parameters and it is not editable.

20241127125057.mp4

@ShiboSoftwareDev
Copy link
Contributor Author

@ShiboSoftwareDev pease check, Now the num_pins behaves like the other parameters and it is not editable.

20241127125057.mp4

that's not what I said. some paramters are readonly and some are not; you'd know from their type definition. look at the old 'Number of Pins' input field to know how to handle num_pins because it is a special case, regardless of whether it is readonly or not. If you find it difficult to understand the terminology I'm using send my comments to chatgpt, give it some context and ask it to explain in simpler terms.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 27, 2025
@github-actions github-actions bot removed the stale label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants