Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/fix/RunFrameForCli-full-viewport #194

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

/fix/RunFrameForCli-full-viewport #194

wants to merge 11 commits into from

Conversation

MustafaMulla29
Copy link

/claim #107

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
runframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 2:31pm

@algora-pbc algora-pbc bot mentioned this pull request Jan 28, 2025
Open
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 28, 2025

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

Anshgrover23
Anshgrover23 requested changes Jan 28, 2025
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Anshgrover23
Anshgrover23 reviewed Jan 28, 2025
View reviewed changes
Copy link

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaMulla29 share any screenshot or video showing you have solved the issue.

@MustafaMulla29
Copy link
Author

image

@MustafaMulla29 share any screenshot or video showing you have solved the issue.

@Anshgrover23
Copy link

@MustafaMulla29 share the before and after screenshot.

@MustafaMulla29
Copy link
Author

MustafaMulla29 commented Jan 29, 2025 •
edited
Loading

@MustafaMulla29 share the before and after screenshot.

Before
before

After
after

sorry for commit with incorrect username, I reverted it.

@Anshgrover23
Copy link

@MustafaMulla29 resolve conflicts.

@MustafaMulla29
Copy link
Author

@Anshgrover23 resolved conflicts, please check!

Anshgrover23
Anshgrover23 requested changes Jan 29, 2025
View reviewed changes
Copy link

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustafaMulla29 you are changing files very frequently, before the fix was in some other file, just stick to one implementation.

@Anshgrover23 Anshgrover23 requested a review from seveibar January 29, 2025 16:06
@MustafaMulla29
Copy link
Author

@MustafaMulla29 you are changing files very frequently, before the fix was in some other file, just stick to one implementation.

Sorry for multiple changes. But this is the last possible implementation from my side.(Recent commit)

@MustafaMulla29
Copy link
Author

@Anshgrover23 can you please check this pr if its correct?

@Anshgrover23
Copy link

@MustafaMulla29 seve will review this one. just paste this pr link by tagging seve on discord of tscircuit.

seveibar
seveibar requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is to automatically size height, not to have a larger fixed height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar requested changes

@Anshgrover23 Anshgrover23 Awaiting requested review from Anshgrover23

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MustafaMulla29 @Anshgrover23 @seveibar @sanjeelvelip2412