Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring codebase structure #25

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ShiboSoftwareDev
Copy link
Collaborator

huge pr and there is a part 2, just want to know:

  • Can I remove the old benchmark script?
  • What parts of my code should I make tests for?

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will answer quedtions separately

@ShiboSoftwareDev
Copy link
Collaborator Author

@seveibar I'm also going to rewrite the readme

@seveibar
Copy link
Contributor

seveibar commented Feb 5, 2025

Yes can remove old benchmark script

re: testing, i think we would want tohave a snapshot for the % of each eval, basically we just want something we can run on ci to make sure nobody reduces our score

additionally, a test for the basic pipelineafter this is packaged for the tscircuit.com ai would be good (later)

@ShiboSoftwareDev ShiboSoftwareDev merged commit 5364f9e into tscircuit:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants