Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix display label in readable netlists #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix display label in readable netlists #6

wants to merge 2 commits into from

Conversation

abhishek818
Copy link

fixes #4
/claim #4

@algora-pbc algora-pbc bot mentioned this pull request Jan 12, 2025
Open
@abhishek818
Copy link
Author

@seveibar up for review.

@Anshgrover23
Copy link
Contributor

@abhishek818 see the issue description and title completely it's not only about pin labels. Before claiming the bounty.

@abhishek818
Copy link
Author

@abhishek818 see the issue description and title completely it's not only about pin labels. Before claiming the bounty.

@Anshgrover23
hey, i have also taken care of that 'undefined' issue, by just adding a null check for it (also if null avoid adding comma prefix).
Are you referring to something else?

@abhishek818
Copy link
Author

@seveibar pinging for review just in case if you missed this.

@seveibar
Copy link
Contributor

@abhishek818 this is good, you need to have some kind of test that showcases what you fixed

@seveibar
Copy link
Contributor

just looked at it on stream!!! https://x.com/seveibar

@seveibar
Copy link
Contributor

0:51:00

seveibar
seveibar reviewed Jan 14, 2025
View reviewed changes
lib/scorePhrase.ts
@@ -15,7 +15,7 @@ const wordQualityScore = {
SCL: 1.2,
RX: 1.15,
TX: 1.15,
GPIO: 1.1,
GP: 1.1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just add GP

seveibar
seveibar reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to pull a readable netlist from a circuit at tscircuit.com it is downloadable from the download menu

lib/scorePhrase.ts
@@ -15,7 +15,7 @@ const wordQualityScore = {
SCL: 1.2,
RX: 1.15,
TX: 1.15,
GPIO: 1.1,
GP: 1.1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just add GP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined in readable netlists, pin labels are too short, just "pin14" instead of full pin labels
3 participants
@abhishek818 @Anshgrover23 @seveibar