Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sending traces to Jaeger with minikube #11

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,21 @@ Then deploy the application:
helm upgrade --install -n $NAMESPACE trustify charts/trustify --values values-minikube.yaml --set-string appDomain=$APP_DOMAIN
```

Install the infrastructure services **with traces enabled**:

```bash
helm upgrade --install --dependency-update -n $NAMESPACE infrastructure charts/trustify-infrastructure --values values-minikube.yaml --set-string keycloak.ingress.hostname=sso$APP_DOMAIN --set-string appDomain=$APP_DOMAIN --set jaeger.enabled=true --set-string jaeger.allInOne.ingress.hosts[0]=jaeger$APP_DOMAIN --set tracing.enabled=true --timeout 10m
```

Then deploy the application **with traces enabled**:

```bash
# Get the collector service name
kubectl get svc
# Install the application
helm upgrade --install -n $NAMESPACE trustify charts/trustify --values values-minikube.yaml --set-string appDomain=$APP_DOMAIN --set tracing.enabled=true --set-string otelCollector="http://infrastructure-jaeger-collector:4317"
```

### Kind

Create a new cluster:
Expand Down
2 changes: 2 additions & 0 deletions charts/trustify/templates/helpers/_infrastructure.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ Arguments (dict):
value: parentbased_traceidratio
- name: OTEL_TRACES_SAMPLER_ARG
value: "0.1"
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: {{ .root.Values.otelCollector }}
{{- end }}

{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/trustify/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
"type": "string",
"description": "The base part of the URLs being generated by the chart.\n\nWhen using OpenShift, this should be the application domain, when can be evaluated by running the following\ncommand: `oc -n openshift-ingress-operator get ingresscontrollers.operator.openshift.io default -o jsonpath='{.status.domain}'`.\n"
},
"otelCollector": {
"type": "string",
"description": "OTEL Collector back-end URL. Example: http://localhost:4317\n"
},
"partOf": {
"type": "string",
"default": "trustify",
Expand Down
4 changes: 4 additions & 0 deletions charts/trustify/values.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ properties:

When using OpenShift, this should be the application domain, when can be evaluated by running the following
command: `oc -n openshift-ingress-operator get ingresscontrollers.operator.openshift.io default -o jsonpath='{.status.domain}'`.
otelCollector:
type: string
description: |
OTEL Collector back-end URL. Example: http://localhost:4317

partOf:
type: string
Expand Down
1 change: 1 addition & 0 deletions charts/trustify/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
appDomain: change-me
otelCollector: "http://localhost:4317"

partOf: trustify
replicas: 1
Expand Down
1 change: 1 addition & 0 deletions values-importers.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
$schema: "charts/trustify/values.schema.json"

appDomain: asdf
otelCollector: "http://localhost:4317"
tracing: {}

modules:
Expand Down
1 change: 1 addition & 0 deletions values-minikube.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
appDomain: change-me
otelCollector: "http://localhost:4317"

tracing: {}

Expand Down
Loading