NAS-133964 / 25.10 / Add chart_metadata to generated app versions file #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
stavros-k
approved these changes
Feb 3, 2025
sonicaj
approved these changes
Feb 3, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have
chart_metadatakey being used to determine min/max scale version check on apps and as we are moving on to adding migrations which will only work in FT, we want to make sure users in EE are not able to consume these versions of the apps as migrations won't run in EE.So temporarily we are adding
chart_metadatakey there so anybody in EE trying to upgrade to these app versions which require migrations to function, has no issues and a nice error is displayed to them.