Docs workflolw #998
Merged
Docs workflolw #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavros-k
requested review from
Qubad786,
Mrt134,
micjohnson777 and
kmoore134
kmoore134
approved these changes
Nov 27, 2024
Qubad786
reviewed
Nov 27, 2024
| message += "\n" | ||
| message += "\n---\n\n" | ||
|
|
||
| if message != "": |
| account_to_notify = ["@truenas/docs-team"] | ||
|
|
||
|
|
||
| def process(changed_files=[], added_files=[]): |
There was a problem hiding this comment.
We should never use mutable args as default args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ixsystems.atlassian.net/browse/NAS-132695
One thing to note is that there is a chance that the comment will not run when PRs are opened from forks.
We will have to re-check
Result: