From e26fba6cf7b862d9a687bbfb084afff00324ce85 Mon Sep 17 00:00:00 2001 From: Benjamin Bischoff Date: Thu, 13 Dec 2018 09:46:08 +0100 Subject: [PATCH] fixed layout issue with long urls --- CHANGELOG.md | 8 ++++++++ example-project/json/scenario_failure.json | 2 +- example-project/json/scenario_with_docstrings.json | 2 +- example-project/pom.xml | 2 +- plugin-code/pom.xml | 2 +- .../src/main/resources/template/css/cluecumber.css | 4 ++++ .../cluecumber/properties/PropertyManagerTest.java | 5 ++++- 7 files changed, 20 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 628415a9..abf526fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. Back to [Readme](README.md). +## [1.6.1] - 2018-12-13 + +### Fixed + +* Long URLs in doc strings and stack traces broke the layout + ## [1.6.0] - 2018-12-12 ### Added @@ -287,6 +293,8 @@ Back to [Readme](README.md). Initial project version on GitHub and Maven Central. +[1.6.1]: https://github.com/trivago/cluecumber-report-plugin/tree/1.6.1 +[1.6.0]: https://github.com/trivago/cluecumber-report-plugin/tree/1.6.0 [1.5.0]: https://github.com/trivago/cluecumber-report-plugin/tree/1.5.0 [1.4.2]: https://github.com/trivago/cluecumber-report-plugin/tree/1.4.2 [1.4.1]: https://github.com/trivago/cluecumber-report-plugin/tree/1.4.1 diff --git a/example-project/json/scenario_failure.json b/example-project/json/scenario_failure.json index 0549b957..395d1513 100755 --- a/example-project/json/scenario_failure.json +++ b/example-project/json/scenario_failure.json @@ -18,7 +18,7 @@ "name": "this step fails", "result": { "duration": 340604218, - "error_message": "java.lang.RuntimeException: this step failed\n\tat Steps.lambda$new$2(Steps.java:14)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat java.lang.reflect.Method.invoke(Method.java:498)\n\tat cucumber.runtime.Utils$1.call(Utils.java:40)\n\tat cucumber.runtime.Timeout.timeout(Timeout.java:16)\n\tat cucumber.runtime.Utils.invoke(Utils.java:34)\n\tat cucumber.runtime.java8.Java8StepDefinition.execute(Java8StepDefinition.java:106)\n\tat cucumber.runtime.StepDefinitionMatch.runStep(StepDefinitionMatch.java:40)\n\tat cucumber.api.TestStep.executeStep(TestStep.java:102)\n\tat cucumber.api.TestStep.run(TestStep.java:83)\n\tat cucumber.api.TestCase.run(TestCase.java:58)\n\tat cucumber.runner.Runner.runPickle(Runner.java:80)\n\tat cucumber.runtime.junit.PickleRunners$NoStepDescriptions.run(PickleRunners.java:140)\n\tat cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:68)\n\tat cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:23)\n\tat org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)\n\tat org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)\n\tat org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)\n\tat org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)\n\tat org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)\n\tat org.junit.runners.ParentRunner.run(ParentRunner.java:363)\n\tat cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:73)\n\tat cucumber.api.junit.Cucumber.runChild(Cucumber.java:99)\n\tat cucumber.api.junit.Cucumber.runChild(Cucumber.java:41)\n\tat org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)\n\tat org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)\n\tat org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)\n\tat org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)\n\tat org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)\n\tat cucumber.api.junit.Cucumber$1.evaluate(Cucumber.java:108)\n\tat org.junit.runners.ParentRunner.run(ParentRunner.java:363)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat java.lang.reflect.Method.invoke(Method.java:498)\n\tat org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)\n\tat org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)\n\tat org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)\n\tat org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)\n\tat org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)\n\tat ✽.this step fails(features/003-one-failing-scenario.feature:3)\n", + "error_message": "http://www.this.is.a.url.that.doesnt.exist.but.is.rather.long.so.it.should.not.break.the.line.in.the.report.de java.lang.RuntimeException: this step failed\n\tat Steps.lambda$new$2(Steps.java:14)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat java.lang.reflect.Method.invoke(Method.java:498)\n\tat cucumber.runtime.Utils$1.call(Utils.java:40)\n\tat cucumber.runtime.Timeout.timeout(Timeout.java:16)\n\tat cucumber.runtime.Utils.invoke(Utils.java:34)\n\tat cucumber.runtime.java8.Java8StepDefinition.execute(Java8StepDefinition.java:106)\n\tat cucumber.runtime.StepDefinitionMatch.runStep(StepDefinitionMatch.java:40)\n\tat cucumber.api.TestStep.executeStep(TestStep.java:102)\n\tat cucumber.api.TestStep.run(TestStep.java:83)\n\tat cucumber.api.TestCase.run(TestCase.java:58)\n\tat cucumber.runner.Runner.runPickle(Runner.java:80)\n\tat cucumber.runtime.junit.PickleRunners$NoStepDescriptions.run(PickleRunners.java:140)\n\tat cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:68)\n\tat cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:23)\n\tat org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)\n\tat org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)\n\tat org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)\n\tat org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)\n\tat org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)\n\tat org.junit.runners.ParentRunner.run(ParentRunner.java:363)\n\tat cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:73)\n\tat cucumber.api.junit.Cucumber.runChild(Cucumber.java:99)\n\tat cucumber.api.junit.Cucumber.runChild(Cucumber.java:41)\n\tat org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)\n\tat org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)\n\tat org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)\n\tat org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)\n\tat org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)\n\tat cucumber.api.junit.Cucumber$1.evaluate(Cucumber.java:108)\n\tat org.junit.runners.ParentRunner.run(ParentRunner.java:363)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)\n\tat org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat java.lang.reflect.Method.invoke(Method.java:498)\n\tat org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)\n\tat org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)\n\tat org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)\n\tat org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)\n\tat org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)\n\tat ✽.this step fails(features/003-one-failing-scenario.feature:3)\n", "status": "failed" } } diff --git a/example-project/json/scenario_with_docstrings.json b/example-project/json/scenario_with_docstrings.json index 2ddabcf3..b83d591f 100755 --- a/example-project/json/scenario_with_docstrings.json +++ b/example-project/json/scenario_with_docstrings.json @@ -33,7 +33,7 @@ "doc_string": { "content_type": "", "line": 4, - "value": "11:43:36.054 karate.env system property was: dev \n11:43:36.110 skipping bootstrap configuration for env: dev - could not find or read file: karate-config-dev.js, prefix: CLASSPATH\n" + "value": "http://www.this.is.a.url.that.doesnt.exist.but.is.rather.long.so.it.should.not.break.the.line.in.the.report.de 11:43:36.054 karate.env system property was: dev \n11:43:36.110 skipping bootstrap configuration for env: dev - could not find or read file: karate-config-dev.js, prefix: CLASSPATH\n" } }, { diff --git a/example-project/pom.xml b/example-project/pom.xml index ad0ac2ab..5535ec48 100644 --- a/example-project/pom.xml +++ b/example-project/pom.xml @@ -6,7 +6,7 @@ de.benjamin-bischoff cluecumber-test-project - 1.6.0 + 1.6.1 UTF-8 diff --git a/plugin-code/pom.xml b/plugin-code/pom.xml index c2e8aa69..83cfafb2 100644 --- a/plugin-code/pom.xml +++ b/plugin-code/pom.xml @@ -6,7 +6,7 @@ com.trivago.rta cluecumber-report-plugin - 1.6.0 + 1.6.1 https://github.com/trivago/cluecumber-report-plugin Cluecumber Maven Plugin for Cucumber Reports diff --git a/plugin-code/src/main/resources/template/css/cluecumber.css b/plugin-code/src/main/resources/template/css/cluecumber.css index 54c87930..169f5607 100644 --- a/plugin-code/src/main/resources/template/css/cluecumber.css +++ b/plugin-code/src/main/resources/template/css/cluecumber.css @@ -166,4 +166,8 @@ button.btn.collapsed:before { button.btn:before { content: 'Hide '; +} + +div.collapse { + width: 100%; } \ No newline at end of file diff --git a/plugin-code/src/test/java/com/trivago/cluecumber/properties/PropertyManagerTest.java b/plugin-code/src/test/java/com/trivago/cluecumber/properties/PropertyManagerTest.java index c7f16c5f..cd614ec8 100644 --- a/plugin-code/src/test/java/com/trivago/cluecumber/properties/PropertyManagerTest.java +++ b/plugin-code/src/test/java/com/trivago/cluecumber/properties/PropertyManagerTest.java @@ -77,7 +77,10 @@ public void logFullPropertiesTest() { customParameters.put("key1", "value1"); customParameters.put("key2", "value2"); propertyManager.setCustomParameters(customParameters); + + propertyManager.setCustomCss("customCss"); + propertyManager.logProperties(); - verify(logger, times(5)).info(anyString()); + verify(logger, times(6)).info(anyString()); } }