From 45116edfcdc35eb8a809e7d92fc265a4cf9da110 Mon Sep 17 00:00:00 2001
From: bbischoff <benjamin.bischoff@trivago.com>
Date: Thu, 23 Jan 2020 11:32:08 +0100
Subject: [PATCH] changed id names, added changelog, updated dependencies

---
 CHANGELOG.md                                         | 12 ++++++++++++
 example-project/pom.xml                              |  4 ++--
 plugin-code/pom.xml                                  | 10 +++++-----
 .../src/main/resources/template/feature-summary.ftl  |  2 +-
 .../src/main/resources/template/scenario-summary.ftl |  6 +++---
 .../src/main/resources/template/step-summary.ftl     |  2 +-
 .../src/main/resources/template/tag-summary.ftl      |  2 +-
 7 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e3b7ca4d..a55fdf2e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,9 +7,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 Back to [Readme](README.md).
 
+## [2.3.2] - 2020-01-23
+
+### Fixed
+
+* Missing feature description in scenario details (#222, contributed by Labouh)
+
+### Added
+
+* Explicit html element ids for better custom css styling (#228, contributed by Labouh)
+
 ## [2.3.1] - 2019-10-15
 
 ### Fixed
+
 * Chart y axis step size in scenario view
 
 ## [2.3.0] - 2019-10-14
@@ -540,6 +551,7 @@ steps with status `pending` or `undefined` (default value is `false`) (#74)
 
 Initial project version on GitHub and Maven Central.
 
+[2.3.2]: https://github.com/trivago/cluecumber-report-plugin/tree/2.3.2
 [2.3.1]: https://github.com/trivago/cluecumber-report-plugin/tree/2.3.1
 [2.3.0]: https://github.com/trivago/cluecumber-report-plugin/tree/2.3.0
 [2.2.0]: https://github.com/trivago/cluecumber-report-plugin/tree/2.2.0
diff --git a/example-project/pom.xml b/example-project/pom.xml
index b2fe3746..ed962435 100644
--- a/example-project/pom.xml
+++ b/example-project/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>de.benjamin-bischoff</groupId>
     <artifactId>cluecumber-test-project</artifactId>
-    <version>2.3.1</version>
+    <version>2.3.2</version>
     <packaging>pom</packaging>
 
     <properties>
@@ -60,7 +60,7 @@
                     <!--<failScenariosOnPendingOrUndefinedSteps>true</failScenariosOnPendingOrUndefinedSteps>-->
 
                     <!-- Optional custom CSS for custom styling -->
-                    <customCss>custom/custom.css</customCss>
+                    <!-- <customCss>custom/custom.css</customCss> -->
 
                     <!-- Optional properties to expand scenario hooks, step hooks and doc strings when scenario details are shown (default: false) -->
                     <!--<expandBeforeAfterHooks>true</expandBeforeAfterHooks>-->
diff --git a/plugin-code/pom.xml b/plugin-code/pom.xml
index 0f1eba6d..938503f4 100644
--- a/plugin-code/pom.xml
+++ b/plugin-code/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.trivago.rta</groupId>
     <artifactId>cluecumber-report-plugin</artifactId>
-    <version>2.3.1</version>
+    <version>2.3.2</version>
     <url>https://github.com/trivago/cluecumber-report-plugin</url>
 
     <name>Cluecumber Maven Plugin for Cucumber Reports</name>
@@ -65,7 +65,7 @@
         <project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
         <maven.compile.encoding>UTF-8</maven.compile.encoding>
 
-        <maven.version>3.6.2</maven.version>
+        <maven.version>3.6.3</maven.version>
         <maven.gpg.plugin.version>1.6</maven.gpg.plugin.version>
         <nexus.staging.maven.plugin.version>1.6.8</nexus.staging.maven.plugin.version>
         <maven.plugin.plugin.version>3.6.0</maven.plugin.plugin.version>
@@ -76,13 +76,13 @@
         <maven.plugin.testing.harness.version>3.3.0</maven.plugin.testing.harness.version>
         <cobertura.maven.plugin>2.7</cobertura.maven.plugin>
         <maven.jar.plugin.version>3.0.2</maven.jar.plugin.version>
-        <plexus.component.annotations.version>2.0.0</plexus.component.annotations.version>
+        <plexus.component.annotations.version>2.1.0</plexus.component.annotations.version>
         <maven.plugin.annotations.version>3.6.0</maven.plugin.annotations.version>
         <maven.source.plugin.version>2.4</maven.source.plugin.version>
         <plexus.utilities.version>3.3.0</plexus.utilities.version>
 
-        <mockito.version>3.1.0</mockito.version>
-        <junit5.vintage.version>5.5.2</junit5.vintage.version>
+        <mockito.version>3.2.4</mockito.version>
+        <junit5.vintage.version>5.6.0</junit5.vintage.version>
         <openpojo.version>0.8.13</openpojo.version>
 
         <gson.version>2.8.6</gson.version>
diff --git a/plugin-code/src/main/resources/template/feature-summary.ftl b/plugin-code/src/main/resources/template/feature-summary.ftl
index 2d729bc4..0fb1d4f4 100644
--- a/plugin-code/src/main/resources/template/feature-summary.ftl
+++ b/plugin-code/src/main/resources/template/feature-summary.ftl
@@ -27,7 +27,7 @@ subheadline=""
 preheadline=""
 preheadlineLink="">
 
-    <div class="row" id="features-summary">
+    <div class="row" id="feature-summary">
         <@page.card width="9" title="Feature Summary Result Chart" subtitle="" classes="">
             <@page.graph />
         </@page.card>
diff --git a/plugin-code/src/main/resources/template/scenario-summary.ftl b/plugin-code/src/main/resources/template/scenario-summary.ftl
index 3ed0b777..99a019d7 100644
--- a/plugin-code/src/main/resources/template/scenario-summary.ftl
+++ b/plugin-code/src/main/resources/template/scenario-summary.ftl
@@ -122,15 +122,15 @@ preheadlineLink="">
                         <br>
                         ${totalNumberOfSkippedScenarios} skipped <@common.status status="skipped"/>
                     <#else>
-                        <a href="javascript:;"
+                        <a href="javascript:"
                            onclick="document.location.hash='anchor-passed';">${totalNumberOfPassedScenarios}
                             passed</a> <@common.status status="passed"/>
                         <br>
-                        <a href="javascript:;"
+                        <a href="javascript:"
                            onclick="document.location.hash='anchor-failed';">${totalNumberOfFailedScenarios}
                             failed</a> <@common.status status="failed"/>
                         <br>
-                        <a href="javascript:;"
+                        <a href="javascript:"
                            onclick="document.location.hash='anchor-skipped';">${totalNumberOfSkippedScenarios}
                             skipped</a> <@common.status status="skipped"/>
                     </#if>
diff --git a/plugin-code/src/main/resources/template/step-summary.ftl b/plugin-code/src/main/resources/template/step-summary.ftl
index 166ec67a..96274a82 100644
--- a/plugin-code/src/main/resources/template/step-summary.ftl
+++ b/plugin-code/src/main/resources/template/step-summary.ftl
@@ -27,7 +27,7 @@ subheadline=""
 preheadline=""
 preheadlineLink="">
 
-    <div class="row" id="steps-summary">
+    <div class="row" id="step-summary">
         <@page.card width="9" title="Step Summary Result Chart" subtitle="" classes="">
             <@page.graph />
         </@page.card>
diff --git a/plugin-code/src/main/resources/template/tag-summary.ftl b/plugin-code/src/main/resources/template/tag-summary.ftl
index cf221989..1b0b0852 100644
--- a/plugin-code/src/main/resources/template/tag-summary.ftl
+++ b/plugin-code/src/main/resources/template/tag-summary.ftl
@@ -27,7 +27,7 @@ subheadline=""
 preheadline=""
 preheadlineLink="">
 
-    <div class="row" id="tags-summary">
+    <div class="row" id="tag-summary">
         <@page.card width="9" title="Tag Summary Result Chart" subtitle="" classes="">
             <@page.graph />
         </@page.card>