From f8e7adc1953050f9dd999b5f8c65bedc259e47e6 Mon Sep 17 00:00:00 2001 From: Benjamin Bischoff Date: Tue, 8 May 2018 10:50:42 +0200 Subject: [PATCH 1/2] added feature description to tool tip --- CHANGELOG.md | 10 ++++++++++ example-project/json/fail.json | 2 +- example-project/json/pass.json | 2 +- example-project/pom.xml | 2 +- plugin-code/pom.xml | 3 ++- .../src/main/resources/template/macros/scenario.ftl | 11 +++++++++-- .../src/main/resources/template/snippets/js.ftl | 2 +- .../src/main/resources/template/tag-summary.ftl | 2 +- 8 files changed, 26 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7d8beb7d..71d96b28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. Back to [Readme](README.md). +## [0.7.1] - 2018-05-08 + +# Added + +Feature description is now shown in the feature tool tip on hover + +# Fixed + +* Chart was not rendered when a scenario contained step data tables + ## [0.7.0] - 2018-04-18 # Changed diff --git a/example-project/json/fail.json b/example-project/json/fail.json index 4cbabff9..553c7cf7 100755 --- a/example-project/json/fail.json +++ b/example-project/json/fail.json @@ -1,6 +1,6 @@ [ { - "description": "", + "description": "This is a feature description 2", "elements": [ { "description": "", diff --git a/example-project/json/pass.json b/example-project/json/pass.json index 2e5388ec..e365f2b5 100755 --- a/example-project/json/pass.json +++ b/example-project/json/pass.json @@ -1,6 +1,6 @@ [ { - "description": "", + "description": "This is a feature description 1", "elements": [ { "description": "", diff --git a/example-project/pom.xml b/example-project/pom.xml index d3c9f770..778f37eb 100644 --- a/example-project/pom.xml +++ b/example-project/pom.xml @@ -6,7 +6,7 @@ de.benjamin-bischoff cluecumber-test-project - 0.7.0 + 0.7.1 UTF-8 diff --git a/plugin-code/pom.xml b/plugin-code/pom.xml index e2bd0928..d9e564fc 100644 --- a/plugin-code/pom.xml +++ b/plugin-code/pom.xml @@ -6,7 +6,7 @@ com.trivago.rta cluecumber-report-plugin - 0.7.0 + 0.7.1 https://github.com/trivago/cluecumber-report-plugin Cluecumber Maven Plugin for Cucumber Reports @@ -132,6 +132,7 @@ ${maven.compiler.source} ${maven.compiler.target} + UTF-8 diff --git a/plugin-code/src/main/resources/template/macros/scenario.ftl b/plugin-code/src/main/resources/template/macros/scenario.ftl index b1de9f97..0e1187ea 100644 --- a/plugin-code/src/main/resources/template/macros/scenario.ftl +++ b/plugin-code/src/main/resources/template/macros/scenario.ftl @@ -21,7 +21,7 @@
- +
@@ -31,11 +31,18 @@ <#list reports as report> + + <#assign tooltipText = ""> + <#if report.description?has_content> + <#assign tooltipText = "${report.description} | "> + + <#assign tooltipText = "${tooltipText}${report.uri}"> + <#list report.elements as element> <#if (skippedRequested && element.skipped) || (failedRequested && element.failed) || (passedRequested && element.passed)>
Feature
${report.name?html} + title="${tooltipText}">${report.name?html} ${element.name?html} diff --git a/plugin-code/src/main/resources/template/snippets/js.ftl b/plugin-code/src/main/resources/template/snippets/js.ftl index 25991da2..308d0ae8 100644 --- a/plugin-code/src/main/resources/template/snippets/js.ftl +++ b/plugin-code/src/main/resources/template/snippets/js.ftl @@ -8,7 +8,7 @@