-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate legacy Azure storage support #24871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a14ffee
to
77e4e65
Compare
77e4e65
to
dc0187d
Compare
wendigo
approved these changes
Feb 2, 2025
I will wait for @electrum to approve this PR before I merge.. and then also send the ones for S3 and GCS |
dc0187d
to
69e44ea
Compare
electrum
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the migration guide around for now seems like a good idea.
Sounds good.. will move them all. |
We are removing the docs for the legacy systems but for now want to keep the migration guides to allow people looking at the current docs to still be able to read how to upgrade. We will remove these docs in the future, potentially as part of the removal of the code, or even later.
629e22e
to
1a5acde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @electrum @wendigo and others
Do we want to potentially move the migration guide to the new doc so we have that still around @electrum ?
Turns out deprecating the properities breaks the tests .. so I will probably have to remove them. Will do the IBM COS one first
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: