Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user what are extractable date/time fields #24192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 20, 2024

Make the error message for invalid extract more helpful.

relates to #24175

Make the error message for invalid `extract` more helpful.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Nov 20, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 20, 2024
@hashhar
Copy link
Member

hashhar commented Nov 20, 2024

have you seen #23002, it's related.

Once you fill out the blanks in this PR I can review it.

@hashhar hashhar self-requested a review November 20, 2024 15:29
@findepi
Copy link
Member Author

findepi commented Dec 5, 2024

have you seen #23002, it's related.

i haven't, thanks for the link
What should i infer from that PR?

Copy link

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Dec 26, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Jan 16, 2025
@mosabua
Copy link
Member

mosabua commented Jan 16, 2025

Looks good to me but maybe @martint or @kasiafi could chime in here and you could reopen @findepi

@findepi findepi reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry stale
Development

Successfully merging this pull request may close these issues.

3 participants