fix(suite-native): hide send for portfolio tracker

[PeKne]

Description

• hides global send button for portfolio tracker device

Related Issue

Resolve #16484

Screenshots:

[coderabbitai]

Walkthrough

The pull request updates how the system determines the availability of sendable accounts on a device. The changes include modifying the selectHasDeviceAnySendAvailableAccount function to add a new parameter, isPortfolioTrackerDevice. A new selector, selectIsPortfolioTrackerDevice, is introduced to assist with this check. The function now immediately returns false when the device is identified as a portfolio tracker, bypassing further account filtering. If the device is not a portfolio tracker, the function proceeds to filter the accounts using the existing logic (filterSendAvailableAccounts) and evaluates whether any accounts remain available. This alteration adjusts the control flow within the selector, ensuring that devices flagged as portfolio trackers are treated differently during the account validation process.

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc20a5d and b61d336.

📒 Files selected for processing (1)

• suite-native/accounts/src/selectors.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: prepare_android_test_app

🔇 Additional comments (2)

suite-native/accounts/src/selectors.ts (2)

21-21: Good addition of required import.

The import of selectIsPortfolioTrackerDevice is correctly placed in alphabetical order within the imports from '@suite-common/wallet-core'.

---

226-233: Clean implementation of the portfolio tracker check.

The modifications to selectHasDeviceAnySendAvailableAccount effectively fulfill the PR objective by:

1. Adding the portfolio tracker check at the beginning of the function
2. Early returning false when a portfolio tracker device is detected
3. Maintaining the original logic for non-portfolio tracker devices

This approach ensures that the send button will be hidden specifically for portfolio tracker devices while preserving functionality for all other device types.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vytick]

should this be true for view only devices in case they have SendAvailableAccounts ?

[PeKne]

Yes, I think so. If user tries to send from view only device, he as able to fill in the send form and then if he continues, the Connect Trezor Screen is displayed. But I will double check, just to make sure.

EDIT: Yes, it is the way I described above. (it happens here)