-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Sentry #17220
base: develop
Are you sure you want to change the base?
chore: upgrade Sentry #17220
Conversation
🚀 Expo preview is ready!
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
suite-common/sentry/src/index.ts
Outdated
dsn: 'https://6d91ca6e6a5d4de7b47989455858b5f6@o117836.ingest.sentry.io/5193825', | ||
autoSessionTracking: false, // do not send analytical data to Sentry | ||
integrations: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To preserve the original behavior with session tracking disabled, you need to remove the default integration browserSessionIntegration
, in my opinion. https://docs.sentry.io/platforms/javascript/guides/react/configuration/integrations/#removing-a-default-integration
https://docs.sentry.io/platforms/javascript/migration/v8-to-v9/#removed-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point I was thinking it disabled by default.
1f54e33
to
7ac4012
Compare
integrations: integrations => [ | ||
...integrations, | ||
// There seems to be no official way how to add captureConsoleIntegration to Sentry in React Native. | ||
captureConsoleIntegration({ levels: ['error'] }) as any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not happy about casting to any
but I was not able to find any other way how to it.
@@ -11,7 +11,7 @@ | |||
}, | |||
"dependencies": { | |||
"@reduxjs/toolkit": "1.9.5", | |||
"@sentry/react-native": "6.5.0", | |||
"@sentry/react-native": "^6.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait until version 7 comes out because v6 is not compatible with v9 core.
Description
Related Issue
Resolve
Screenshots: