fix(mobile): remove mocked selectors

[Nodonisko]

Description

We were using some mocked selectors instead of real ones which already caused some strange bugs in past. This should use real selectors everywhere.

Notes for QA:

• test functionality with device connecting, disconnecting, discovery, fw update etc

Related Issue

Previously I tried this #15878 but these selectors are used in big number of test and it's significantly harder to mocked them then, so this later solution should be simpler and keeps mocking simple.

Screenshots:

[coderabbitai]

Walkthrough

The changes update the state management structure for device-related selectors. The revised code now imports two additional selectors, selectDeviceDiscovery and selectSelectedDevice, alongside selectDevices. Within the extraDependencies export, a new mapping named selectDevice is introduced, which points to selectSelectedDevice, and the selectDeviceDiscovery selector is added. Additionally, modifications are reflected in the module @suite-common/wallet-core where methods for selectDeviceDiscovery and selectSelectedDevice are added, and the signature for selectDevices is updated. The overall structure of the existing dependencies remains consistent while incorporating the new device-related selectors.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5766733 and c861b13.

📒 Files selected for processing (1)

• suite-native/state/src/extraDependencies.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: prepare_android_test_app
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (2)

suite-native/state/src/extraDependencies.ts (2)

7-11: LGTM! Import changes align with PR objectives.

The addition of real device-related selectors from '@suite-common/wallet-core' aligns with the goal of replacing mocked selectors to improve stability.

---

47-49:

✅ Verification successful

LGTM! Selector additions enhance device management capabilities.

The new selectors improve the device management functionality:

• selectDevice provides a semantic alias for selectSelectedDevice
• selectDeviceDiscovery supports device discovery requirements

Let's verify the integration of these selectors:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify the usage of new selectors across the codebase

# Check for usage of selectSelectedDevice and selectDeviceDiscovery
echo "Checking usage of new selectors..."
rg "selectSelectedDevice|selectDeviceDiscovery" --type ts

# Check for any remaining mock implementations
echo "Checking for remaining mock implementations..."
rg "mock.*Device.*Discovery|mock.*Selected.*Device" --type ts

Length of output: 52689

---

LGTM! New selectors are well integrated and enhance device management across the codebase.

• The alias selectDevice correctly maps to selectSelectedDevice, ensuring backward compatibility while improving clarity.
• The addition of selectDeviceDiscovery has been verified in both business logic and test files, confirming its proper integration.
• Test mocks in extraDependenciesMock.ts align with expected patterns and do not raise concerns.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.