Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): show testnets during account import only if enabled #17183

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Feb 24, 2025

Related Issue

Resolve #17160

@yanascz yanascz requested a review from a team as a code owner February 24, 2025 11:26
@yanascz yanascz added the mobile Suite Lite issues and PRs label Feb 24, 2025
Copy link

coderabbitai bot commented Feb 24, 2025

Walkthrough

The changes update the component logic for displaying testnet network items. The code now imports an additional selector to determine if testnets are enabled and replaces the existing variable for testnet symbols. Specifically, a new variable is introduced to capture the testnet enablement state, and the JSX rendering logic is modified to conditionally render the testnet section only when testnets are enabled. These updates refine the control flow in the component by decoupling the testnet feature flag from the network symbols, ensuring that testnet networks are displayed in the UI only if the corresponding state is active.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3187da7 and 47f013a.

📒 Files selected for processing (1)
  • suite-native/module-accounts-import/src/components/SelectableNetworkList.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: prepare_android_test_app
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Setup and Cache Dependencies
🔇 Additional comments (3)
suite-native/module-accounts-import/src/components/SelectableNetworkList.tsx (3)

8-11: LGTM! Import changes align with PR objective.

The addition of selectAreTestnetsEnabled selector enables the conditional rendering of testnets, which directly addresses the PR's goal.


38-39: LGTM! Clean implementation of testnet state management.

The separation of testnet symbol selection and enablement state improves code clarity and maintainability. The variable naming is also more consistent now.


48-54: LGTM! Effective implementation of conditional testnet rendering.

The conditional rendering ensures testnets are only shown when enabled, which directly fulfills the PR's objective. The implementation maintains a consistent structure with the mainnet section.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yanascz yanascz merged commit 826bcd2 into develop Feb 24, 2025
18 of 20 checks passed
@yanascz yanascz deleted the fix/native/portfolio-tracker-testnets branch February 24, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testnets available in portfolio tracker on production build
2 participants