feat(trading): exclude NON_SUITE receive option when noExternalAddress tag

[FreeWall]

Description

Hide Use an account that isn’t in Suite option (NON_SUITE) in receive form, controlled by noExternalAddress tag in quote data

Related Issue

Resolve #17137

Screenshots:

Before

After

For multiple accounts:

For single account, the dropdown has only 1 option so it's disabled

[github-actions]

🚀 Expo preview is ready!

• Project → trezor-suite-preview
• Platforms → android, ios
• Scheme → trezorsuitelite
• Runtime Version → 26
• More info

Learn more about 𝝠 Expo Github Action

[coderabbitai]

Walkthrough

The pull request contains two primary sets of changes. First, the version of the @types/invity-api dependency is updated from ^1.1.2 to ^1.1.3 in multiple package.json files (found in the packages/suite and suite-common/trading directories). Second, a new boolean parameter nonSuiteAccount is introduced to several parts of the code. This parameter is added to the function signatures of getSelectAccountOptions and useTradingVerifyAccount, and it is incorporated into the TradingVerifyAccountProps interface. Additionally, the hook calls in the TradingOfferBuy and TradingOfferExchange components have been updated to pass the nonSuiteAccount value based on whether certain tags (e.g., 'noExternalAddress') are present in the selected quote. Dependencies and memoization hooks are also updated accordingly to include the new parameter.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a6b98b and 2e45806.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (6)

• packages/suite/package.json (1 hunks)
• packages/suite/src/hooks/wallet/trading/form/useTradingVerifyAccount.tsx (4 hunks)
• packages/suite/src/types/trading/tradingVerify.ts (1 hunks)
• packages/suite/src/views/wallet/trading/common/TradingSelectedOffer/TradingOfferBuy/TradingOfferBuy.tsx (1 hunks)
• packages/suite/src/views/wallet/trading/common/TradingSelectedOffer/TradingOfferExchange/TradingOfferExchange.tsx (1 hunks)
• suite-common/trading/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• suite-common/trading/package.json
• packages/suite/package.json

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: methods / core_in_popup
• GitHub Check: run_android_e2e_tests

🔇 Additional comments (5)

packages/suite/src/types/trading/tradingVerify.ts (1)

22-25: LGTM! Clear and well-typed interface addition.

The new nonSuiteAccount boolean property is appropriately added to the TradingVerifyAccountProps interface, making the feature flag's type explicit.

packages/suite/src/views/wallet/trading/common/TradingSelectedOffer/TradingOfferExchange/TradingOfferExchange.tsx (1)

29-32: LGTM! Correct implementation of the feature flag.

The nonSuiteAccount value is properly derived from the quote tags using optional chaining and negation, ensuring the NON_SUITE option is hidden when 'noExternalAddress' tag is present.

packages/suite/src/views/wallet/trading/common/TradingSelectedOffer/TradingOfferBuy/TradingOfferBuy.tsx (1)

18-21: LGTM! Consistent implementation across components.

The nonSuiteAccount logic matches the implementation in TradingOfferExchange, ensuring consistent behavior across different trading flows.

packages/suite/src/hooks/wallet/trading/form/useTradingVerifyAccount.tsx (2)

28-50: LGTM! Clean implementation of conditional NON_SUITE option.

The getSelectAccountOptions function correctly uses the nonSuiteAccount parameter to conditionally include the NON_SUITE option in the returned array.

---

107-116: LGTM! Proper memoization with updated dependencies.

The useMemo hook's dependency array correctly includes nonSuiteAccount to ensure the options are recalculated when the flag changes.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.