Run less tests #17038
Run less tests #17038
Conversation
WalkthroughThis pull request removes a large number of GitHub Actions workflow files that previously automated various CI/CD processes in the repository. The deleted workflows included tasks for translation synchronization, automatic rebasing of pull requests, building desktop and mobile applications, executing multiple testing suites (end-to-end, unit, shell, etc.), managing releases, version bumps, and enforcing commit message or project assignment standards. In addition, workflows related to code validation, AWS deployments, and release configurations across different environments have been removed. Conversely, a new workflow named “dummy” has been introduced with simulated test steps. A documentation file was also updated by adding an extra line. No alterations were made to any exported or public entities beyond the changes in workflow declarations. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/tests/e2e-playwright-suite.md (1)
145-145: Remove or Replace Placeholder TextThe line
"blabla delete delete"appears to be placeholder text and includes a duplicate word ("delete delete"). This could confuse readers of the documentation. Consider removing this line or replacing it with meaningful content.🧰 Tools
🪛 LanguageTool
[duplication] ~145-~145: Possible typo: you repeated a word.
Context: ...t show-report ./path/to/report` blabla delete delete(ENGLISH_WORD_REPEAT_RULE)
.github/workflows/dummy.yml (2)
15-15: Remove Trailing SpacesA trailing space exists on line 15. Removing it will help maintain clean formatting.
- github.event_name != 'issue_comment' || + github.event_name != 'issue_comment' ||🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 15-15: trailing spaces
(trailing-spaces)
33-33: Enforce Newline at End of FileThere is no newline character at the end of the file. Adding one will adhere to common file formatting standards.
- run: sleep 120 # Simulate a long-running test + run: sleep 120 # Simulate a long-running test +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (46)
.github/workflows/bot-crowdin-sync.yml(0 hunks).github/workflows/bot-rebase.yml(0 hunks).github/workflows/build-desktop-apps.yml(0 hunks).github/workflows/build-node-bridge.yml(0 hunks).github/workflows/build-storybook.yml(0 hunks).github/workflows/build-suite-native-preview.yml(0 hunks).github/workflows/build-suite-web.yml(0 hunks).github/workflows/check-code-validation.yml(0 hunks).github/workflows/check-codeql-analysis.yml(0 hunks).github/workflows/check-commit-message.yml(0 hunks).github/workflows/check-project-assignment.yml(0 hunks).github/workflows/check-shell-validation.yml(0 hunks).github/workflows/dummy.yml(1 hunks).github/workflows/release-connect-bump-versions.yml(0 hunks).github/workflows/release-connect-init.yml(0 hunks).github/workflows/release-connect-intermediary.yml(0 hunks).github/workflows/release-connect-npm.yml(0 hunks).github/workflows/release-connect-v9-production.yml(0 hunks).github/workflows/release-connect-v9-rollback.yml(0 hunks).github/workflows/release-connect-v9-staging.yml(0 hunks).github/workflows/release-suite-coin-icons.yml(0 hunks).github/workflows/release-suite-definitions.yml(0 hunks).github/workflows/release-suite-desktop-web-production.yml(0 hunks).github/workflows/release-suite-desktop-web-staging.yml(0 hunks).github/workflows/release-suite-message-system-config.yml(0 hunks).github/workflows/release-suite-native-develop.yml(0 hunks).github/workflows/release-suite-native-production.yml(0 hunks).github/workflows/suite-native-monthly-version-bump.yml(0 hunks).github/workflows/template-connect-popup-test-params.yml(0 hunks).github/workflows/template-connect-test-params.yml(0 hunks).github/workflows/test-blockchain-link.yml(0 hunks).github/workflows/test-connect-misc.yml(0 hunks).github/workflows/test-connect-popup.yml(0 hunks).github/workflows/test-connect-web.yml(0 hunks).github/workflows/test-connect.yml(0 hunks).github/workflows/test-misc.yml(0 hunks).github/workflows/test-request-manager.yml(0 hunks).github/workflows/test-suite-desktop-e2e.yml(0 hunks).github/workflows/test-suite-native-e2e-android.yml(0 hunks).github/workflows/test-suite-native-e2e-ios.yml(0 hunks).github/workflows/test-suite-web-e2e-pw.yml(0 hunks).github/workflows/test-suite-web-e2e.yml(0 hunks).github/workflows/test-suite-web-nightly.yml(0 hunks).github/workflows/test-transport.yml(0 hunks).github/workflows/update-connect-config.yml(0 hunks)docs/tests/e2e-playwright-suite.md(1 hunks)
💤 Files with no reviewable changes (44)
- .github/workflows/check-commit-message.yml
- .github/workflows/build-suite-web.yml
- .github/workflows/check-code-validation.yml
- .github/workflows/test-request-manager.yml
- .github/workflows/release-suite-coin-icons.yml
- .github/workflows/test-connect-web.yml
- .github/workflows/test-suite-web-nightly.yml
- .github/workflows/release-suite-message-system-config.yml
- .github/workflows/release-suite-desktop-web-production.yml
- .github/workflows/test-connect.yml
- .github/workflows/suite-native-monthly-version-bump.yml
- .github/workflows/test-blockchain-link.yml
- .github/workflows/release-connect-v9-staging.yml
- .github/workflows/template-connect-test-params.yml
- .github/workflows/test-connect-popup.yml
- .github/workflows/release-connect-v9-production.yml
- .github/workflows/release-connect-npm.yml
- .github/workflows/release-suite-native-develop.yml
- .github/workflows/release-suite-desktop-web-staging.yml
- .github/workflows/test-suite-desktop-e2e.yml
- .github/workflows/check-codeql-analysis.yml
- .github/workflows/test-connect-misc.yml
- .github/workflows/test-suite-native-e2e-ios.yml
- .github/workflows/update-connect-config.yml
- .github/workflows/template-connect-popup-test-params.yml
- .github/workflows/check-shell-validation.yml
- .github/workflows/release-connect-v9-rollback.yml
- .github/workflows/test-transport.yml
- .github/workflows/bot-crowdin-sync.yml
- .github/workflows/build-suite-native-preview.yml
- .github/workflows/release-suite-definitions.yml
- .github/workflows/release-suite-native-production.yml
- .github/workflows/release-connect-bump-versions.yml
- .github/workflows/release-connect-init.yml
- .github/workflows/build-node-bridge.yml
- .github/workflows/test-misc.yml
- .github/workflows/build-desktop-apps.yml
- .github/workflows/test-suite-native-e2e-android.yml
- .github/workflows/test-suite-web-e2e-pw.yml
- .github/workflows/test-suite-web-e2e.yml
- .github/workflows/check-project-assignment.yml
- .github/workflows/bot-rebase.yml
- .github/workflows/release-connect-intermediary.yml
- .github/workflows/build-storybook.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/dummy.yml
[error] 15-15: trailing spaces
(trailing-spaces)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
🪛 LanguageTool
docs/tests/e2e-playwright-suite.md
[duplication] ~145-~145: Possible typo: you repeated a word.
Context: ...t show-report ./path/to/report` blabla delete delete
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: dummy-job
🔇 Additional comments (4)
.github/workflows/dummy.yml (4)
1-2: Workflow Naming ClarityThe workflow name "Dummy Workflow" clearly indicates its placeholder or testing nature. This is acceptable given the current context.
3-11: Event Triggers ConfigurationThe workflow correctly triggers on pull requests (for creation and updates), issue comments (when created), and pushes to branches matching
release/2*. The usage of the branch pattern appears to be in line with GitHub Actions globbing rules.
12-18: Job Condition and Safety CheckThe multi-line
if:condition is designed to run the job when the event is not an issue comment, or when the comment contains/run-tests. This configuration is logical for ensuring that only intentional test runs occur. However, please verify that in non-issue_comment events GitHub Actions safely handlesgithub.event.comment.body(or defaults it to an empty string) to avoid potential evaluation issues.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 15-15: trailing spaces
(trailing-spaces)
19-27: Concurrency Configuration ConsiderationsUsing a dynamically constructed concurrency group (based on the event type) is an effective way to avoid unnecessary duplicate runs. One point for review: the
cancel-in-progressoption is set to false. If the goal is to truly "run less tests," you might consider setting this to true to cancel redundant in-progress jobs when a new event in the same group is triggered.
Description
Related Issue
Resolve
Screenshots: