-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run less tests #17031
Run less tests #17031
Conversation
WalkthroughThe pull request removes a large number of GitHub Actions workflows from the repository, with files deleted that previously handled tasks such as translation synchronization, pull request rebasing, desktop and web application builds, version bumps, release processes, code validations, and various testing processes including unit tests, end-to-end tests, and security analyses. In addition, workflows for updating configuration, commit message checks, and shell script validations were also removed. One new workflow file—described as a dummy workflow—was added, which includes logic for triggering on pull requests and issue comments. A minor modification was also made in a documentation file by adding a new line at the end. Overall, the changes significantly reduce the number of automated workflows in the repository and introduce a single new, non-critical testing workflow. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
/run-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/tests/e2e-playwright-suite.md (1)
145-145
: Remove Unintended Line with Repeated TextThe new line "blabla delete delete" appears to be an accidental inclusion—likely a leftover from a previous edit or debug note—and contains a repeated phrase that the static analysis tool flagged as a potential typo. Please verify if this line is necessary; if not, kindly remove it to keep the documentation clear.
- blabla delete delete
🧰 Tools
🪛 LanguageTool
[duplication] ~145-~145: Possible typo: you repeated a word.
Context: ...t show-report ./path/to/report` blabla delete delete(ENGLISH_WORD_REPEAT_RULE)
.github/workflows/dummy.yml (4)
5-5
: Remove Trailing Spaces in Workflow Trigger.
Line 5 contains trailing whitespace. Please remove the extra spaces to conform to YAMLlint standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 5-5: trailing spaces
(trailing-spaces)
15-15
: Trim Trailing Spaces in the Conditional Expression.
Line 15 has trailing whitespace that should be removed to adhere to formatting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 15-15: trailing spaces
(trailing-spaces)
29-29
: Correct Indentation in Step Definition.
YAMLlint reports incorrect indentation on line 29. The expected indentation level is 4 spaces, but 6 were found. Adjust the indentation to ensure consistent YAML formatting.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 29-29: wrong indentation: expected 4 but found 6
(indentation)
33-33
: Append a Newline at End of File.
Static analysis indicates that the file is missing a newline at the end. Please ensure a newline character is added to comply with YAML best practices.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (46)
.github/workflows/bot-crowdin-sync.yml
(0 hunks).github/workflows/bot-rebase.yml
(0 hunks).github/workflows/build-desktop-apps.yml
(0 hunks).github/workflows/build-node-bridge.yml
(0 hunks).github/workflows/build-storybook.yml
(0 hunks).github/workflows/build-suite-native-preview.yml
(0 hunks).github/workflows/build-suite-web.yml
(0 hunks).github/workflows/check-code-validation.yml
(0 hunks).github/workflows/check-codeql-analysis.yml
(0 hunks).github/workflows/check-commit-message.yml
(0 hunks).github/workflows/check-project-assignment.yml
(0 hunks).github/workflows/check-shell-validation.yml
(0 hunks).github/workflows/dummy.yml
(1 hunks).github/workflows/release-connect-bump-versions.yml
(0 hunks).github/workflows/release-connect-init.yml
(0 hunks).github/workflows/release-connect-intermediary.yml
(0 hunks).github/workflows/release-connect-npm.yml
(0 hunks).github/workflows/release-connect-v9-production.yml
(0 hunks).github/workflows/release-connect-v9-rollback.yml
(0 hunks).github/workflows/release-connect-v9-staging.yml
(0 hunks).github/workflows/release-suite-coin-icons.yml
(0 hunks).github/workflows/release-suite-definitions.yml
(0 hunks).github/workflows/release-suite-desktop-web-production.yml
(0 hunks).github/workflows/release-suite-desktop-web-staging.yml
(0 hunks).github/workflows/release-suite-message-system-config.yml
(0 hunks).github/workflows/release-suite-native-develop.yml
(0 hunks).github/workflows/release-suite-native-production.yml
(0 hunks).github/workflows/suite-native-monthly-version-bump.yml
(0 hunks).github/workflows/template-connect-popup-test-params.yml
(0 hunks).github/workflows/template-connect-test-params.yml
(0 hunks).github/workflows/test-blockchain-link.yml
(0 hunks).github/workflows/test-connect-misc.yml
(0 hunks).github/workflows/test-connect-popup.yml
(0 hunks).github/workflows/test-connect-web.yml
(0 hunks).github/workflows/test-connect.yml
(0 hunks).github/workflows/test-misc.yml
(0 hunks).github/workflows/test-request-manager.yml
(0 hunks).github/workflows/test-suite-desktop-e2e.yml
(0 hunks).github/workflows/test-suite-native-e2e-android.yml
(0 hunks).github/workflows/test-suite-native-e2e-ios.yml
(0 hunks).github/workflows/test-suite-web-e2e-pw.yml
(0 hunks).github/workflows/test-suite-web-e2e.yml
(0 hunks).github/workflows/test-suite-web-nightly.yml
(0 hunks).github/workflows/test-transport.yml
(0 hunks).github/workflows/update-connect-config.yml
(0 hunks)docs/tests/e2e-playwright-suite.md
(1 hunks)
💤 Files with no reviewable changes (44)
- .github/workflows/check-shell-validation.yml
- .github/workflows/check-commit-message.yml
- .github/workflows/test-request-manager.yml
- .github/workflows/test-connect-web.yml
- .github/workflows/release-connect-v9-rollback.yml
- .github/workflows/release-suite-coin-icons.yml
- .github/workflows/test-connect-misc.yml
- .github/workflows/release-connect-init.yml
- .github/workflows/check-codeql-analysis.yml
- .github/workflows/test-suite-desktop-e2e.yml
- .github/workflows/build-node-bridge.yml
- .github/workflows/test-blockchain-link.yml
- .github/workflows/bot-crowdin-sync.yml
- .github/workflows/bot-rebase.yml
- .github/workflows/test-connect.yml
- .github/workflows/update-connect-config.yml
- .github/workflows/test-transport.yml
- .github/workflows/release-suite-message-system-config.yml
- .github/workflows/test-suite-native-e2e-ios.yml
- .github/workflows/build-desktop-apps.yml
- .github/workflows/check-code-validation.yml
- .github/workflows/release-suite-native-develop.yml
- .github/workflows/check-project-assignment.yml
- .github/workflows/test-suite-web-e2e.yml
- .github/workflows/test-suite-web-e2e-pw.yml
- .github/workflows/release-suite-desktop-web-staging.yml
- .github/workflows/suite-native-monthly-version-bump.yml
- .github/workflows/release-connect-v9-staging.yml
- .github/workflows/build-suite-native-preview.yml
- .github/workflows/release-suite-definitions.yml
- .github/workflows/template-connect-popup-test-params.yml
- .github/workflows/test-connect-popup.yml
- .github/workflows/release-connect-intermediary.yml
- .github/workflows/build-storybook.yml
- .github/workflows/test-misc.yml
- .github/workflows/template-connect-test-params.yml
- .github/workflows/release-suite-native-production.yml
- .github/workflows/release-connect-bump-versions.yml
- .github/workflows/test-suite-web-nightly.yml
- .github/workflows/release-connect-v9-production.yml
- .github/workflows/release-connect-npm.yml
- .github/workflows/release-suite-desktop-web-production.yml
- .github/workflows/test-suite-native-e2e-android.yml
- .github/workflows/build-suite-web.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/dummy.yml
[error] 5-5: trailing spaces
(trailing-spaces)
[error] 15-15: trailing spaces
(trailing-spaces)
[warning] 29-29: wrong indentation: expected 4 but found 6
(indentation)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
🪛 LanguageTool
docs/tests/e2e-playwright-suite.md
[duplication] ~145-~145: Possible typo: you repeated a word.
Context: ...t show-report ./path/to/report` blabla delete delete
(ENGLISH_WORD_REPEAT_RULE)
🔇 Additional comments (4)
.github/workflows/dummy.yml (4)
1-2
: Workflow Name Defined Appropriately.
The workflow name"Dummy Workflow"
is clearly defined and explains the purpose of this file.
12-27
: Job Configuration and Concurrency Setup Verified.
The job"dummy-job"
is well configured with the conditional execution clause and a dynamic concurrency group based on event type. Ensure the conditional expression meets the intended behavior for both pull request and issue comment triggers.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 15-15: trailing spaces
(trailing-spaces)
19-26
: Dynamic Concurrency Group Expression Looks Good.
The use of a dynamic concurrency group using inline expressions is an effective approach. No issues found here.
32-33
: Review the Long Test Simulation Step.
The step usingsleep 60
simulates a long-running test. Please verify that this placeholder aligns with the intent to "run less tests" and consider adding documentation or a more descriptive comment if future developers need context.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
/run-tests |
Description
Related Issue
Resolve
Screenshots: