Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): develop build pipeline fix #16918

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(suite-native): develop build pipeline fix #16918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-suite-native-develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup EAS
uses: expo/expo-github-action@v8
with:
eas-version: latest
eas-version: 14.7.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

LGTM! Fixed EAS version improves build stability.

Pinning the EAS version to 14.7.1 instead of using 'latest' is a good practice as it:

  • Ensures consistent builds across different environments
  • Prevents unexpected breaking changes from newer versions
  • Makes builds more reproducible and debuggable

Let's verify this version matches PR #16887:

🏁 Script executed:

#!/bin/bash
# Description: Check if EAS version is consistent with PR #16887
git fetch origin pull/16887/head:pr-16887
git show pr-16887:.github/workflows/release-suite-native-develop.yml | grep 'eas-version'

Length of output: 263

EAS Version Discrepancy Detected
The EAS version in the current branch is set to 14.7.1, while PR #16887 still uses latest. This misalignment means the current change does not match the referenced PR. Please confirm if the intentional improvement to pin the version at 14.7.1 should override the settings in PR #16887 or if further adjustments are needed.

token: ${{ secrets.EXPO_TOKEN }}
- name: Install libs
run: yarn workspaces focus @suite-native/app
Expand Down
Loading