Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite-data): update tor binaries #16806

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

komret
Copy link
Contributor

@komret komret commented Feb 4, 2025

update tor to 0.4.8.13

Copy link

coderabbitai bot commented Feb 4, 2025

Walkthrough

This pull request updates the metadata for several binary files and the associated update script within the tor package. The changes include updating the SHA256 hashes and file sizes for the tor binaries on different platforms: linux-arm64, linux-x64, mac-arm64, and mac-x64. Each binary now has a new hash value reflecting content modifications and an increased file size. Additionally, the update script (update.sh) has been modified to increment the version numbers for the CRX files (CRX_VER updated from 1_0_36 to 1_0_37 and CRX_LINUX_ARM_VER updated from 1_0_5 to 1_0_6), which affects the URLs used to download these files. No changes have been made to the declarations of exported or public entities.

Suggested reviewers

  • Hermez-cz

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06bbb97 and 5e1811f.

⛔ Files ignored due to path filters (1)
  • packages/suite-data/files/bin/tor/win-x64/tor.exe is excluded by !**/*.exe
📒 Files selected for processing (5)
  • packages/suite-data/files/bin/tor/linux-arm64/tor (1 hunks)
  • packages/suite-data/files/bin/tor/linux-x64/tor (1 hunks)
  • packages/suite-data/files/bin/tor/mac-arm64/tor (1 hunks)
  • packages/suite-data/files/bin/tor/mac-x64/tor (1 hunks)
  • packages/suite-data/files/bin/tor/update.sh (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • packages/suite-data/files/bin/tor/mac-x64/tor
  • packages/suite-data/files/bin/tor/linux-x64/tor
  • packages/suite-data/files/bin/tor/mac-arm64/tor
  • packages/suite-data/files/bin/tor/linux-arm64/tor
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: build-web
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: build-web
🔇 Additional comments (1)
packages/suite-data/files/bin/tor/update.sh (1)

4-5: Update Version Variables

The version variables CRX_VER and CRX_LINUX_ARM_VER have been updated to 1_0_37 and 1_0_6, respectively. This update is in line with the PR objectives and affects the download URLs for the CRX files (see lines 27–33). Please verify that these new versions correctly reflect the intended Tor binary updates and that downstream processes (e.g., hash verification) will work as expected.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@komret komret added the tor Issues that could affect Tor label Feb 4, 2025
@komret komret enabled auto-merge (rebase) February 4, 2025 13:46
@MiroslavProchazka MiroslavProchazka self-requested a review February 4, 2025 14:20
@komret komret merged commit 80064fe into develop Feb 4, 2025
33 of 34 checks passed
@komret komret deleted the chore/update-tor-binaries branch February 4, 2025 14:20
@bosomt
Copy link
Contributor

bosomt commented Feb 4, 2025

QA OK

✅ Windows 11
✅ macARM
✅ maxINTEL
✅ linux

2025-02-04T15:27:18.880Z - INFO(tor): Bootstrap - 10% - Connected to a relay
2025-02-04T15:27:18.914Z - INFO(tor): Bootstrap - 14% - Handshaking with a relay
2025-02-04T15:27:18.986Z - INFO(tor): Bootstrap - 15% - Handshake with a relay done
2025-02-04T15:27:18.986Z - INFO(tor): Bootstrap - 20% - Establishing an encrypted directory connection
2025-02-04T15:27:19.037Z - INFO(tor): Bootstrap - 25% - Asking for networkstatus consensus
2025-02-04T15:27:19.065Z - INFO(tor): Bootstrap - 30% - Loading networkstatus consensus
2025-02-04T15:27:19.425Z - DEBUG(window-control): Blur
2025-02-04T15:27:19.462Z - INFO(tor): Bootstrap - 45% - Asking for relay descriptors
2025-02-04T15:27:19.491Z - INFO(tor): Bootstrap - 72% - Loading relay descriptors
2025-02-04T15:27:19.905Z - INFO(tor): Bootstrap - 75% - Loaded enough directory info to build circuits
2025-02-04T15:27:19.932Z - INFO(tor): Bootstrap - 90% - Handshake finished with a relay to build circuits
2025-02-04T15:27:19.932Z - INFO(tor): Bootstrap - 95% - Establishing a Tor circuit
2025-02-04T15:27:20.099Z - INFO(tor): Bootstrap - 100% - Done
bosomt@Mac Downloads % ./tor
Feb 04 16:25:14.680 [notice] Tor 0.4.8.13 running on Darwin with Libevent 2.1.12-stable, OpenSSL 3.4.0, Zlib 1.3.1, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.

Info:

  • Suite version: desktop 25.2.0 (3925aec)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.2.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3B1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tor Issues that could affect Tor
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants