fix(metadata): mitigation when inconsistent data is loaded

(cherry picked from commit 5873cca)
trezor · Oct 9, 2023 · 6c8d061 · 6c8d061
1 parent 794fabd
commit 6c8d061
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/packages/suite/jest.config.js b/packages/suite/jest.config.js
@@ -50,10 +50,10 @@ module.exports = {
     ],
     coverageThreshold: {
         global: {
-            statements: 63,
-            branches: 51,
+            statements: 62.9,
+            branches: 50.7,
             functions: 61,
-            lines: 65,
+            lines: 64.2,
         },
     },
     modulePathIgnorePatterns: [

diff --git a/packages/suite/src/actions/suite/metadataActions.ts b/packages/suite/src/actions/suite/metadataActions.ts
@@ -379,6 +379,19 @@ export const fetchMetadata =
             aesKey,
         );
 
+        // validation of fetched data structure. in theory, user may save any data in metadata file (although it is very unlikely)
+        // so we should make sure that it at least matches AccountLabels types
+        if (entity.type === 'account') {
+            if (!decryptedData.addressLabels) {
+                console.error('fetchMetadata: addressLabels missing in metadata file');
+                decryptedData.addressLabels = {};
+            }
+            if (!decryptedData.outputLabels) {
+                console.error('fetchMetadata: outputLabels missing in metadata file');
+                decryptedData.outputLabels = {};
+            }
+        }
+
         return {
             fileName,
             data: decryptedData,