Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix core_unit_rust_test w/ ASAN #4743

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 6, 2025

Fixes nightly pipeline failures caused (probably) by #4650.

error[E0463]: can't find crate for `ufmt_macros`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ufmt-0.2.0/src/lib.rs:234:9
    |
234 | pub use ufmt_macros::uwrite;
    |         ^^^^^^^^^^^ can't find crate

https://github.com/trezor/trezor-firmware/actions/runs/13687506189/job/38274414168

Copy link

github-actions bot commented Mar 6, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata requested review from romanz and matejcik March 6, 2025 11:43
@mmilata mmilata self-assigned this Mar 6, 2025
@romanz
Copy link
Contributor

romanz commented Mar 6, 2025

Seems like an issue in ufmt:

~/src/ufmt $ git lg -1
* d95831b Jorge Aparicio:  (HEAD -> main, tag: ufmt-utils-v0.2.0, origin/main, origin/HEAD) ufmt-utils v0.2.0 (2 years, 7 months ago)

~/src/ufmt $ RUSTFLAGS='-Z sanitizer=address' cargo build
   Compiling proc-macro2 v1.0.94
   Compiling unicode-ident v1.0.18
   Compiling syn v1.0.109
   Compiling ufmt-write v0.1.0 (/home/rzeyde/src/ufmt/write)
   Compiling quote v1.0.39
   Compiling ufmt-macros v0.3.0 (/home/rzeyde/src/ufmt/macros)
   Compiling ufmt v0.2.0 (/home/rzeyde/src/ufmt)
error[E0463]: can't find crate for `ufmt_macros`
   --> src/lib.rs:234:9
    |
234 | pub use ufmt_macros::uwrite;
    |         ^^^^^^^^^^^ can't find crate

error[E0463]: can't find crate for `ufmt_macros`
   --> src/lib.rs:239:9
    |
239 | pub use ufmt_macros::uwriteln;
    |         ^^^^^^^^^^^ can't find crate

error[E0463]: can't find crate for `ufmt_macros`
   --> src/lib.rs:247:13
    |
247 |     pub use ufmt_macros::uDebug;
    |             ^^^^^^^^^^^ can't find crate

For more information about this error, try `rustc --explain E0463`.
error: could not compile `ufmt` (lib) due to 3 previous errors

@mmilata
Copy link
Member Author

mmilata commented Mar 6, 2025

Apparently you need to specify an explicit --target: rust-lang/rust#132109

Explains why building through Makefile works. Since we're not running what cargo build produces, let's just skip it in the ASAN CI job.

@mmilata mmilata merged commit 04611d2 into main Mar 6, 2025
96 checks passed
@mmilata mmilata deleted the mmilata/ci-fix-rust-test-asan branch March 6, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

2 participants