Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow running firmware based on allow_run_with_secret flag #4738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TychoVrahe
Copy link
Contributor

This PR modifies behavior of secret provisioning on devices with locked bootloader.

Now, firmware with allow_run_with_secret flag will be allowed to run even if it doesn't have full trust.

fixes #4649

@TychoVrahe TychoVrahe self-assigned this Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/secret_flags branch from d7e337b to 3dcfa26 Compare March 5, 2025 14:57
@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/secret_flags branch from 3dcfa26 to 493fee1 Compare March 5, 2025 15:02
@TychoVrahe TychoVrahe marked this pull request as ready for review March 5, 2025 15:26
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner March 5, 2025 15:27
@TychoVrahe TychoVrahe requested review from matejcik and cepetr and removed request for prusnak March 5, 2025 15:27
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

Incorrect use of trust-all flag in secret_prepare_fw
2 participants