Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "..." ellipsis on "show_more" #4737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use "..." ellipsis on "show_more" #4737

wants to merge 1 commit into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Mar 5, 2025

Follow-up of #4601. When confirming long messages the first page should show a classic ellipsis (...) instead of the ellipsis icon which might make the user believe that the continue button leads to the next page.

Screenshots

Model T

image

TS3

image

TS5

image

@ibz ibz self-assigned this Mar 5, 2025
@ibz ibz linked an issue Mar 5, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Mar 5, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz force-pushed the ibz/show-more-ellipsis branch from f039906 to b6b8363 Compare March 5, 2025 10:51
@ibz ibz force-pushed the ibz/show-more-ellipsis branch from b6b8363 to da1f382 Compare March 5, 2025 11:28
@ibz
Copy link
Contributor Author

ibz commented Mar 5, 2025

@Hannsek / @lapohoda Please confirm the UI!

@ibz ibz marked this pull request as ready for review March 5, 2025 11:28
@ibz ibz requested review from matejcik and prusnak as code owners March 5, 2025 11:28
@ibz ibz requested review from obrusvit and removed request for prusnak March 5, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

Replace ellipsis icon with "..."
1 participant