add device ID to prodtest #4735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/prodtest/device_id
branch
from
287d44d to
2330174
Compare
cepetr
requested changes
Mar 6, 2025
| screen_prodtest_info(dom, strlen(dom), dom + sizeof(MODEL_IDENTIFIER) - 1, | ||
| strlen(dom) - sizeof(MODEL_IDENTIFIER) + 1); | ||
| char device_id[32] = {0}; | ||
| if ((sectrue == flash_otp_read(FLASH_OTP_BLOCK_DEVICE_ID, 0, |
There was a problem hiding this comment.
How about this version that uses fewer hardcoded constants and modified condition for detection whether the block is programmed or not:
char device_id[FLASH_OTP_BLOCK_SIZE];
if ((sectrue == flash_otp_read(FLASH_OTP_BLOCK_DEVICE_ID, 0,
(uint8_t *)device_id, sizeof(device_id)) &&
(device_id[0] != 0xFF)) {
screen_prodtest_info(device_id, strnlen(device_id, sizeof(device_id) - 1));
}| strlen(dom) - sizeof(MODEL_IDENTIFIER) + 1); | ||
| char device_id[32] = {0}; | ||
| if ((sectrue == flash_otp_read(FLASH_OTP_BLOCK_DEVICE_ID, 0, | ||
| (uint8_t *)device_id, 32) && |
There was a problem hiding this comment.
Shouldn't we show batch id as before if the device id is not present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds device ID storing capability - OTP block is allocated and commands for writing and reading device ID are added to prodtest.
The QR code in prodtest is altered to show device ID instead of batch.