Show checklist page #4673
Draft
Show checklist page #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bieleluk
force-pushed
the
bieleluk/eckhart-checklist
branch
from
5f640f5 to
a797856
Compare
- build - directory structure - bootloader UI and assets copied from delizia - FirmwareUI trait functions are empty - Python layout functions are copied from delizia except some of more complicated ones which raise NotImplemented for now
- TextScreen is a full-screen component for (paginated) texts - it's supposed to wrap FormattedText or Paragraphs
[no changelog]
- a static "custom shape" for eckhart layout which displays screen overlay around the borders
- HoldToConfirmAnim is driven by the ActionBar in case the right_button is configured with `long_press` - HoldToConfirmAnim optionally draws an Header overaly with custom text - disabling animations is respected - easing function is not yet finalized - a few minor fixes along the way
- also switch corner icons to 4px width
bieleluk
force-pushed
the
bieleluk/eckhart-checklist
branch
from
a797856 to
7797845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
show_checklistFirmwareUI trait function for EckhartThere is one deviation from the Figma, where the number in an inactive item does not have a different font.
With the current API, this is not possible to achieve because the checkbox items are passed as
TStringparameters. I would suggest to change the API and correct this deviation once the Eckhart stuff is merged in the mainmain