Debuglink timing out fix #4655
Open
Debuglink timing out fix #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
added
the
translations
|
matejcik
force-pushed
the
matejcik/debuglink-timing-out
branch
from
ef0638f to
237540f
Compare
matejcik
force-pushed
the
matejcik/debuglink-timing-out
branch
from
6f67eee to
0f01352
Compare
also take the opportunity to switch to new style typing annotations syntax
...avoiding a problem where, if the timing is unfortunate, the reply may get lost when a workflow is ending
matejcik
force-pushed
the
matejcik/debuglink-timing-out
branch
2 times, most recently
from
2212550 to
3056b49
Compare
romanz
reviewed
Feb 26, 2025
| continue | ||
| if timeout is not None and time.time() - start > timeout: | ||
| raise TransportException("Timeout reading UDP packet") | ||
| time.sleep(0.001) |
There was a problem hiding this comment.
Not sure why do we need time.sleep() here, since the socket has a timeout set too:
| # XXX Due to a bug, the reply may get lost at the end of a workflow. | ||
| # We assume that no single input event takes more than 5 seconds to process, | ||
| # and give up waiting after that. | ||
| self._call(messages.DebugLinkGetState(return_empty_state=True), timeout=5) |
There was a problem hiding this comment.
So just to be sure - we raise an exception here, right?
Asking, since IIRC there was a suggestion to ignore the timeout (i.e. to assume the request has been processed by the device), but then I would suggest also logging that there was an ignored timeout.
There was a problem hiding this comment.
Maybe we can use an environment variable to set the timeout?
IIUC, it may take the device more than 5 seconds to respond, e.g. when running WipeDevice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.