Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use middle button to confirm paginated content on TS3 #4627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Feb 13, 2025

We eventually aim to replace all "hold to confirm" with "middle button" on TS3. Currently it is a mix of both and this PR, which is a follow-up of #4601, does the change for the confirmation of paginated content.

@ibz ibz self-assigned this Feb 13, 2025
@ibz ibz linked an issue Feb 13, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 13, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz force-pushed the ibz/caesar-confirm branch 5 times, most recently from e506560 to 7dd41df Compare February 13, 2025 14:46
@ibz ibz marked this pull request as ready for review February 17, 2025 08:04
@ibz ibz requested a review from prusnak as a code owner February 17, 2025 08:04
@ibz ibz requested review from obrusvit and removed request for prusnak February 17, 2025 08:05
@ibz ibz force-pushed the ibz/caesar-confirm branch from a6c0709 to 2834ca0 Compare March 4, 2025 12:27
@ibz ibz force-pushed the ibz/caesar-confirm branch from 2834ca0 to 807f1b5 Compare March 5, 2025 15:19
@ibz ibz requested a review from matejcik as a code owner March 5, 2025 15:19
@ibz ibz force-pushed the ibz/caesar-confirm branch from 807f1b5 to a4e1326 Compare March 6, 2025 08:36
@ibz ibz force-pushed the ibz/caesar-confirm branch from a4e1326 to 827a122 Compare March 6, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

Replace "hold to confirm" with "middle button"
1 participant