Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use autoPatchelfHook from pinned nixpkgs for emulators #2194

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 29, 2022

NixOS recently switched to different autoPatchelfHook implementation which doesn't work for us in NixOS/nixpkgs#149731. This PR forces the use of the older implementation as a temporary measure.

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

why isn't the new impl working, btw?

@mmilata
Copy link
Member Author

mmilata commented Mar 29, 2022

I'm having trouble comprehending what the shell code in NixOS/nixpkgs#149731 does but it seems that now running autoPatchelf emulators/trezor-emu-* does not modify the emulator binaries at all.

@mmilata mmilata merged commit 0407e78 into master Mar 29, 2022
@mmilata mmilata deleted the mmilata/pinned-autopatchelf branch March 29, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants