Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ellipsis icon with "..." #4623

Open
ibz opened this issue Feb 12, 2025 · 2 comments · May be fixed by #4737
Open

Replace ellipsis icon with "..." #4623

ibz opened this issue Feb 12, 2025 · 2 comments · May be fixed by #4737
Assignees
@ibz

Comments

@ibz
Copy link
Contributor

ibz commented Feb 12, 2025

In confirm_value_intro we should use "..." rather than the arrow icon to indicate that the text is not complete, because using the icon suggests that we are actually paginating through the text, which we are not in this case.

Image
Image
Image
@ibz ibz self-assigned this Feb 12, 2025
@ibz ibz mentioned this issue Feb 12, 2025
Merged
@ibz
Copy link
Contributor Author

ibz commented Mar 5, 2025

@Hannsek Do we actually want this for TS5 as well? Or is it clear enough in that case - due to the footer text...

@ibz ibz linked a pull request Mar 5, 2025 that will close this issue
Use "..." ellipsis on "show_more" #4737
Open
@Hannsek
Copy link
Contributor

Hannsek commented Mar 5, 2025

Yes, we want it for TS5 as well. 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibz ibz

Labels
None yet
Projects
Firmware
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use "..." ellipsis on "show_more" trezor/trezor-firmware
2 participants
@ibz @Hannsek