Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "hold to confirm" with "middle button" #4622

Open
ibz opened this issue Feb 12, 2025 · 1 comment · May be fixed by #4627
Open

Replace "hold to confirm" with "middle button" #4622

ibz opened this issue Feb 12, 2025 · 1 comment · May be fixed by #4627
Assignees
Labels
T3B1 Trezor Safe 3 (U5)

Comments

@ibz
Copy link
Contributor

ibz commented Feb 12, 2025

We might eventually want to replace all instances of "hold to confirm" with the "middle button".

For now the most important place to do it is in confirm_more, which is used to confirm long messages.

It should look like this:

image

I am creating this issue so that I can work on #4601 without thinking about this change because it seems to affect many other places and it makes testing & reviewing that PR unnecessarily complicated, but eventually we can reuse this issue for other PRs dealing with TS3 "hold to confirm" throughout the code base.

@ibz ibz added the T3B1 Trezor Safe 3 (U5) label Feb 12, 2025
@ibz ibz self-assigned this Feb 12, 2025
@Hannsek
Copy link
Contributor

Hannsek commented Feb 12, 2025

Note: If we proceed with this change, we'll need to adjust the tutorial flow. "Hold to confirm" currently appears alongside the middle confirmation, and we shouldn't have the middle confirmation in the tutorial twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T3B1 Trezor Safe 3 (U5)
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants