Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM tests for SP3, SP4, SP5 #33

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Add RPM tests for SP3, SP4, SP5 #33

merged 3 commits into from
Apr 26, 2024

Conversation

rtorrero
Copy link
Contributor

This PR adds some basic testing for the playbooks, using the RPM installation method in

  • SP3
  • SP4
  • SP5

It:

  • Runs playbook.yml
  • Does a simple curl test to the readyness endpoint (/api/readyz
  • Runs playbook.cleanup.yml

3 new machines have been deployed in azure for this purpose. I'm currently adding the required variables to the repository secrets

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check looks good!
But let's use a matrix, it looks the perfect place for that

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!
Merge if the stage is green!

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtorrero rtorrero merged commit 8d9a4e6 into main Apr 26, 2024
6 checks passed
@rtorrero rtorrero deleted the add-ci-test branch April 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants