Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message for verify alerting env's step #25

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

EMaksy
Copy link
Member

@EMaksy EMaksy commented Feb 19, 2024

A small follow-up PR to improve the fail and success msg in the role containers tasks in the "Verify that alerting configuration ..." step

Thanks to @CDimonaco for pointing out 👍 that json configuration may not be the correct naming. Changed to playbook variables.

@EMaksy EMaksy force-pushed the improve_log_message_alerting branch from ac1aba3 to 65a07df Compare February 19, 2024 13:37
@EMaksy EMaksy self-assigned this Feb 19, 2024
@EMaksy EMaksy added the enhancement New feature or request label Feb 19, 2024
@EMaksy EMaksy requested a review from CDimonaco February 19, 2024 13:37
@EMaksy EMaksy force-pushed the improve_log_message_alerting branch from 65a07df to 523ee2b Compare February 19, 2024 13:40
@EMaksy EMaksy requested review from rtorrero and arbulu89 February 19, 2024 13:44
@EMaksy EMaksy marked this pull request as ready for review February 19, 2024 15:31
@EMaksy EMaksy merged commit a1a7e6a into main Feb 20, 2024
5 checks passed
@EMaksy EMaksy deleted the improve_log_message_alerting branch February 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants