Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate storage ID on repository creation #8619

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Feb 6, 2025

Closes #8618

Change Description

Background

This change completes the validation process of the storage ID while creating a repository

Testing Details

Added controller tests to cover all the scenarios

Breaking Change?

No

@N-o-Z N-o-Z requested a review from a team February 6, 2025 19:20
@N-o-Z N-o-Z self-assigned this Feb 6, 2025
@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog msb labels Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Feb 6, 2025

E2E Test Results - Quickstart

11 passed

Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Check my comments though.

pkg/config/config.go Outdated Show resolved Hide resolved
@N-o-Z N-o-Z changed the title Catalog: Validate storage ID on repository creation Validate storage ID on repository creation Feb 6, 2025
Co-authored-by: itaigilo <itai.gilo@treeverse.io>
@N-o-Z N-o-Z enabled auto-merge (squash) February 6, 2025 19:38
@N-o-Z N-o-Z merged commit 012a2ab into master Feb 6, 2025
38 checks passed
@N-o-Z N-o-Z deleted the task/catalog-create-repo-storage-id-8618 branch February 6, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog msb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog: CreateRepository: Validate storage id exists
2 participants