Add WebUI plugins infra #8588
Merged
Add WebUI plugins infra #8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Base automatically changed from
task/add-storage-config-list-response
to
master
February 3, 2025 17:36
nadavsteindler
requested changes
Feb 4, 2025
pkg/api/controller.go
Outdated
| } | ||
| // TODO (niro): Needs to be populated | ||
| storageListCfg := apigen.StorageConfigList{} | ||
| storageCfg, _ := c.getStorageConfig(config.SingleBlockstoreID) |
There was a problem hiding this comment.
Is it ok that we swallowed the error here?
pkg/api/controller.go
Outdated
| } | ||
|
|
||
| writeResponse(w, r, http.StatusOK, storageConfig) | ||
| storageCfg, _ := c.getStorageConfig(config.SingleBlockstoreID) |
There was a problem hiding this comment.
Is it ok that we swallowed the error here?
pkg/config/config.go
Outdated
| @@ -211,12 +226,147 @@ type Blockstore struct { | |||
| } `mapstructure:"gs"` | |||
| } | |||
|
|
|||
| func (b *Blockstore) GetStorageByID(id string) AdapterConfig { | |||
There was a problem hiding this comment.
It's not clear to me how these million changes to config relate to webui plugin infra???
# Conflicts: # pkg/api/controller.go # pkg/block/azure/adapter_test.go # pkg/block/gs/adapter_test.go # pkg/block/local/adapter_test.go # pkg/block/s3/adapter_test.go # pkg/config/config.go
|
@nadavsteindler I needed to merge master into it, sry about that. |
nadavsteindler
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8586.
Change Description
Allow adding WebUI plugins.