Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lakectl: Remove ingest command #8567

Merged
merged 2 commits into from
Jan 31, 2025
Merged

lakectl: Remove ingest command #8567

merged 2 commits into from
Jan 31, 2025

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Jan 29, 2025

Closes #8566

Change Description

Background

Command was deprecated a long time ago. Time to remove

@N-o-Z N-o-Z added area/lakectl Issues related to lakeFS' command line interface (lakectl) exclude-changelog PR description should not be included in next release changelog labels Jan 29, 2025
@N-o-Z N-o-Z requested a review from a team January 29, 2025 20:17
@N-o-Z N-o-Z self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

♻️ PR Preview 5bebecb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

itaigilo
itaigilo reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM, code-wise.

And I'm in for removing code!
But why the ingest cli command isn't needed anymore?

@N-o-Z N-o-Z requested a review from a team January 30, 2025 12:07
@N-o-Z N-o-Z merged commit c58338e into master Jan 31, 2025
38 of 39 checks passed
@N-o-Z N-o-Z deleted the task/remove-ingest-command-8566 branch January 31, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

Assignees

@N-o-Z N-o-Z

Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ingest command from lakectl
2 participants
@N-o-Z @itaigilo