Add --storage-id flag to Repo Create CLI

cmd/lakectl/cmd/repo_create.go

@@ -25,14 +25,18 @@ var repoCreateCmd = &cobra.Command{
 		clt := getClient()
 		u := MustParseRepoURI("repository URI", args[0])
 		fmt.Println("Repository:", u)
+
 		defaultBranch, err := cmd.Flags().GetString("default-branch")
 		if err != nil {
 			DieErr(err)
 		}
+		storageID, _ := cmd.Flags().GetString("storage-id")
+
 		resp, err := clt.CreateRepositoryWithResponse(cmd.Context(),
 			&apigen.CreateRepositoryParams{},
 			apigen.CreateRepositoryJSONRequestBody{
 				Name:             u.Repository,
+				StorageId:        &storageID,
 				StorageNamespace: args[1],
 				DefaultBranch:    &defaultBranch,
 			})
@@ -48,6 +52,7 @@ var repoCreateCmd = &cobra.Command{
 //nolint:gochecknoinits
 func init() {
 	repoCreateCmd.Flags().StringP("default-branch", "d", DefaultBranch, "the default branch of this repository")
+	repoCreateCmd.Flags().String("storage-id", "", "")
 
 	repoCmd.AddCommand(repoCreateCmd)
 }

cmd/lakectl/cmd/repo_create_bare.go

@@ -20,16 +20,21 @@ var repoCreateBareCmd = &cobra.Command{
 		clt := getClient()
 		u := MustParseRepoURI("repository URI", args[0])
 		fmt.Println("Repository:", u)
+
 		defaultBranch, err := cmd.Flags().GetString("default-branch")
 		if err != nil {
 			DieErr(err)
 		}
+		storageID, _ := cmd.Flags().GetString("storage-id")
+
 		bareRepo := true
+
 		resp, err := clt.CreateRepositoryWithResponse(cmd.Context(), &apigen.CreateRepositoryParams{
 			Bare: &bareRepo,
 		}, apigen.CreateRepositoryJSONRequestBody{
 			DefaultBranch:    &defaultBranch,
 			Name:             u.Repository,
+			StorageId:        &storageID,
 			StorageNamespace: args[1],
 		})
 		DieOnErrorOrUnexpectedStatusCode(resp, err, http.StatusCreated)
@@ -44,6 +49,7 @@ var repoCreateBareCmd = &cobra.Command{
 //nolint:gochecknoinits
 func init() {
 	repoCreateBareCmd.Flags().StringP("default-branch", "d", DefaultBranch, "the default branch name of this repository (will not be created)")
+	repoCreateBareCmd.Flags().String("storage-id", "", "")
 
 	repoCmd.AddCommand(repoCreateBareCmd)
 }

docs/reference/cli.md

@@ -2626,6 +2626,7 @@ lakectl repo create lakefs://my-repo s3://my-bucket
 ```
   -d, --default-branch string   the default branch of this repository (default "main")
   -h, --help                    help for create
+      --storage-id string       
 ```
 
 
@@ -2724,6 +2725,7 @@ lakectl create-bare lakefs://my-repo s3://my-bucket
 ```
   -d, --default-branch string   the default branch name of this repository (will not be created) (default "main")
   -h, --help                    help for create-bare
+      --storage-id string       
 ```
 
 

esti/lakectl_test.go

@@ -64,6 +64,16 @@ func TestLakectlBasicRepoActions(t *testing.T) {
 	newStorage := storage + "/new-storage/"
 	RunCmdAndVerifyFailureWithFile(t, Lakectl()+" repo create lakefs://"+repoName+" "+newStorage, false, "lakectl_repo_create_not_unique", vars)
 
+	// Validate the --storage-id flag (currently only allowed to be empty)
+	repoNameSID := generateUniqueRepositoryName()
+	storageSID := generateUniqueStorageNamespace(repoNameSID)
+	vars = map[string]string{
+		"REPO":    repoNameSID,
+		"STORAGE": storageSID,
+		"BRANCH":  mainBranch,
+	}
+	RunCmdAndVerifySuccessWithFile(t, Lakectl()+" repo create lakefs://"+repoNameSID+" "+storageSID+" --storage-id \"\"", false, "lakectl_repo_create", vars)
+
 	// Fails due to the usage of repos for isolation - esti creates repos in parallel and
 	// the output of 'repo list' command cannot be well-defined
 	// RunCmdAndVerifySuccessWithFile(t, Lakectl()+" repo list", false, "lakectl_repo_list_1", vars)