Request TTFB metric for GetObject API #8556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
added
area/API
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
arielshaqed
approved these changes
Jan 27, 2025
| @@ -4564,6 +4565,11 @@ func (c *Controller) GetObject(w http.ResponseWriter, r *http.Request, repositor | |||
| w.Header().Set("Content-Length", fmt.Sprint(entry.Size)) | |||
| } | |||
|
|
|||
| // time to first byte - include out part of the processing without the actual data transfer | |||
| requestTTFBHistograms. | |||
There was a problem hiding this comment.
This is a bit unfortunate: we will get GetObject TTFB on a different metric, possibly with different fields. But I also understand that if we report it on the same metric then summing that metric will be count GetObject TTFB twice - also unfortunate.
There was a problem hiding this comment.
True. Note that summing the underlaying block adapters ttfb can include other operations that under the hood perform GetObject that uses the same block adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8503
Change Description
Background
Metric that will help us measure the GetObject API call's time during a request that does not involve the user's object content. This metric, GetObject Time to First Byte (TTFB), is crucial for understanding the initial latency of fetching an object and differentiating it from subsequent data transfer times.
New Feature
This Pull Request introduces a new metric: api_request_ttfb_duration_seconds. It measures the time elapsed from when a GetObject request is initiated until the first byte of data is sent back to the client.
Testing Details
The changes were tested by:
Breaking Change?
No, this change does not break any existing functionality (API, CLI, Clients). The new metric is added without modifying any existing endpoints or behaviors.