Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jekyll version for document contribution #8020

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

kesarwam
Copy link
Contributor

@kesarwam kesarwam commented Aug 1, 2024

Change Description

Got following error when using "docker run" command to test the docs changes locally:
activesupport-7.0.8 requires ruby version >= 2.7.0, which is incompatible with the current version, ruby 2.6.3p62

Background

Changed jekyll version to 4.2.2 from 3.8 to fix the issue.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kesarwam kesarwam requested a review from ozkatz August 1, 2024 16:07
Copy link

github-actions bot commented Aug 1, 2024

♻️ PR Preview 1a789be has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link

github-actions bot commented Aug 1, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Aug 1, 2024

E2E Test Results - Quickstart

10 passed

@kesarwam kesarwam requested a review from N-o-Z August 1, 2024 18:01
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Aug 1, 2024
@kesarwam kesarwam enabled auto-merge (squash) August 1, 2024 18:45
@kesarwam kesarwam disabled auto-merge August 1, 2024 20:05
@kesarwam kesarwam enabled auto-merge (squash) August 1, 2024 20:05
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@ozkatz ozkatz disabled auto-merge August 2, 2024 16:28
@kesarwam kesarwam merged commit 0e00620 into master Aug 2, 2024
36 of 37 checks passed
@kesarwam kesarwam deleted the docs/contribute-to-docs-change-jekyll-version branch August 2, 2024 16:29
@kesarwam kesarwam added the docs Improvements or additions to documentation label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants